Reformat compressed materialization functions #14470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adjusted failing test case after consulting with @lnkuiper . |
Merge orderThe function formatting PRs should be merged in this order (all pointing to Feature branch): |
|
Thanks! Looks great |
Mytherin
added a commit
that referenced
this pull request
Oct 24, 2024
### Merge order The function formatting PRs should be merged in this order (all pointing to Feature branch): - [14470 - Reformat compressed materialization functions](#14470) - [14489 - Reformat arithmetic operators](#14489) (this PR) - [14495 - Reformat nested and sequence functions](#14495) ### Note on name conventions Struct names in generated header file: `operator_functions.hpp` all end with `Fun`; (this are the functions registered to the catalog). The `GetFunctions()` methods returns a `ScalarFunctionSet` - AddFun - SubtractFun - DivideFun - MultiplyFun - OperatorAddFun - OperatorSubtractFun - OperatorMultiplyFun - OperatorFloatDivideFun - OperatorIntegerDivideFun Header file: `operators.hpp` contains the following structs: - AddFunction - SubtractFunction They contain a `GetFunction()` utility method that returns a `ScalarFunction` with a specific signature, rather then the whole ScalarFunctionSet
Mytherin
added a commit
that referenced
this pull request
Oct 25, 2024
### Merge order The function formatting PRs should be merged in this order (all pointing to Feature branch): - [14470 - Reformat compressed materialization functions](#14470) - [14489 - Reformat arithmetic operators](#14489) - [14495 - Reformat nested and sequence functions](#14495) (this PR) - [14530 - Reformat aggregate functions](#14530)
c-herrewijn
deleted the
PR_reformat_compressed_materialization_functions
branch
Mytherin
added a commit
that referenced
this pull request
Oct 28, 2024
### Merge order The function formatting PRs should be merged in this order (all pointing to Feature branch): - [14470 - Reformat compressed materialization functions](#14470) - [14489 - Reformat arithmetic operators](#14489) - [14495 - Reformat nested and sequence functions](#14495) - [14530 - Reformat aggregate functions](#14530) (this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.