Output extension to a sub-directory that respect the input mode/feature #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That respect the input parameters
carlopi
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I though about and solving this generally (= in duckdb Makefile), with having a postprocessing step where extensions are copied to build/release/extensions/${duckdb_version}/${platform}/${name}.duckdb_extension[.wasm], since that will also allow to use the folder as a local extension directory, basically SET custom_extension_repository='/path/to/folder';
Stuff might move more that direction, but for not this is still more clean.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the
build_loadable.shscripts output every extension underloadable_extensionsfolder.This PR outputs them under
loadable_extensions/$MODE/$FEATUREwhereMODEandFEATUREare the parameters provided in input to select the source directory (eg.mode=relperf feature=mvp)