Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while reading again a parquet file after browser reload #1658

Open
1 task done
ericemc3 opened this issue Mar 4, 2024 · 28 comments
Open
1 task done

Error while reading again a parquet file after browser reload #1658

ericemc3 opened this issue Mar 4, 2024 · 28 comments

Comments

@ericemc3
Copy link

ericemc3 commented Mar 4, 2024

What happens?

Executing twice the same request, after reloading the shell page, yields an error.

To Reproduce

in https://shell.duckdb.org/, execute :

FROM 'https://static.data.gouv.fr/resources/communes-2023-format-parquet/20240122-085355/communes2023.parquet' 
SELECT codgeo WHERE epci = '200039865' ;

then reload the browser and execute that same query again.

On windows and with Chrome or Edge, i get:
Invalid Error: TProtocolException: Invalid data

codgeo column, which is also the first of the dataset, seems to be responsible.

With Firefox, no issue.

OS:

Win11

DuckDB Version:

10.0.0

DuckDB Client:

shell wasm1.28.1-dev159.0

Full Name:

eric mauviere

Affiliation:

icem7

Have you tried this on the latest nightly build?

I have tested with a nightly build

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

  • Yes, I have
@szarnyasg szarnyasg transferred this issue from duckdb/duckdb Mar 4, 2024
@carlopi
Copy link
Collaborator

carlopi commented Mar 4, 2024

Hi @ericemc3, can you share the result of PRAGMA user_agent on the SQL side?

I am aware of a problem with threads, but on the browser I tested it was NOT enable by default, but your setup is somewhat different.

IFF the result contains wasm_threads, I am aware of the problem and working on a fix. You can specify explicitly the bundle going to https://shell.duckdb.org/?bundle=eh

IFF the result is wasm_eh, this is a new problem, and I will later look at that.

@carlopi
Copy link
Collaborator

carlopi commented Mar 4, 2024

(and thanks @szarnyasg, this looks like a duckdb/duckdb-wasm specific problem)

@ericemc3
Copy link
Author

ericemc3 commented Mar 4, 2024

Hi @carlopi,
thank you for your prompt reaction.
I get
┌─────────────────────────────┐
│ user_agent │
╞═════════════════════════════╡
│ duckdb/v0.10.0(wasm_eh) cpp │

and the same issue with https://shell.duckdb.org/?bundle=eh

Please note that it works fine with Firefox (with the same user_agent displayed). So it looks like a Chrome/Edge specific issue as well.

@dude0001
Copy link
Contributor

dude0001 commented Mar 4, 2024

The same thing can be duplicated in DuckDB-WASM v1.28.0 (DuckDB v0.9.1). I thought this was an issue in my app and was still troubleshooting as a low priority, so I haven't reported an issue yet. I just saw this pop up so thought I'd share we see this in v1.28.0 as well. I have worked around it for the moment by fetching the files outside of DuckDB doing registerFileBuffer and read_parquet over the registered files instead of URLs of the parquet files.

@timothyhoward
Copy link

timothyhoward commented May 6, 2024

I've been experiencing this same issue while using Evidence (@evidence-dev/evidence), which uses @duckdb/duckdb-wasm as a dependency. Seems to be affecting Windows, and only Edge/Chrome. Page may load initially or error out, displaying Invalid error: TProtocolException: Invalid data. Turning off caching, or going into Incognito/InPrivate mode, and the query/page works correctly. We're querying Parquet files using the URL, just like this issue.

image

Affecting 1.28.0 (the Evidence dependency version) and the latest build 1.28.1-dev190.0.

@fboerman
Copy link

fboerman commented May 6, 2024

im running into this quite often with evidence. is there a workaround form duckdb-wasm side?

@carlopi
Copy link
Collaborator

carlopi commented May 6, 2024

What is the value of the 'Content-Type' header for the parquet file being fetched ?

To get that, even just opening browser console, select network, instruct duckdb-wasm to fetch the relevant resource, select the relevant row clicking on it, then there is a Headers tab, look for 'Content-Type'.

If that is 'text/plain', it might be connected to this problem: #1580 that is connected to a problem in the spec + implementation of it by Web-browsers.


Independently of the first question question, couple of other ones.
Do you contol the server ?
Can you share a URL that demo this (ideally with a repro within shell.duckdb.org)?

@fboerman
Copy link

fboerman commented May 6, 2024

hi @carlopi content-type is application/octet-stream when I start evidence and it starts pulling in parquet. I do not think its related to that issue given that that bug is firefox specific. this one is the other way around, being solely chrome and edge specific. I dont think I ever managed to get it in firefox.

yes I control the server, you can go to reports.coreflowbased.eu and register a free account to test it out. thats my website which from time to time throws this error. if you get a database timeout simply refresh the site thats a different bug

@carlopi
Copy link
Collaborator

carlopi commented May 6, 2024

That bug is 2 bugs in one, one in Chrome and one in Firefox.

But that's not so relevant. I have no idea how to reproduce within the setting of your website, if you can give some instructions, I might be able to give it a try tomorrow.

@timothyhoward
Copy link

timothyhoward commented May 7, 2024

@carlopi Content-Type for the Parquet files is application/octet-stream here as well. I feel this is definitely a caching issue, as when the cache is disabled in Chrome/Edge, everything runs correctly.

Here's where the exception occurs. I tried looking up the status code 42 but couldn't find a reference.
image

@timothyhoward
Copy link

timothyhoward commented May 8, 2024

Can also confirm, the application works perfectly in Firefox on the same system (Windows 10), so it's confined to Edge and Chrome on Windows. Seems to be the exact same issue as the one @ericemc3 has described in the DuckDB Shell.

Edit: I've mitigated the issue on my application by disabling caching through the 'Cache-Control' header for parquet files. Error does not appear in Chrome/Edge with caching on Parquet files off.

carlopi added a commit to carlopi/duckdb-wasm that referenced this issue May 8, 2024
This emerged while investigating duckdb#1658, but reproduction is not deterministic so hard to say
@carlopi
Copy link
Collaborator

carlopi commented May 8, 2024

I managed to reproduce on a Windows machine, I am very puzzled by this bug given it's non deterministic.
I found something strange that might be connected, fix in #1733 will likely be in either way (since it makes sense) and we can then revaluate.

carlopi added a commit that referenced this issue May 8, 2024
This emerged while investigating #1658, but reproduction is not deterministic so hard to say
@carlopi
Copy link
Collaborator

carlopi commented May 10, 2024

At the moment I am unable to reproduce this (on shell.duckdb.org, currently at @duckdb/duckdb-wasm@1.28.1-dev194.0), but hard to say whether this is properly fixed in all cases.

@timothyhoward
Copy link

At the moment I am unable to reproduce this (on shell.duckdb.org, currently at @duckdb/duckdb-wasm@1.28.1-dev194.0), but hard to say whether this is properly fixed in all cases.

Hi @carlopi,
Thank you for looking into the issue. Unfortunately, still occurring for me - the shell here (at 1.28.1-dev194.0) continues to produce the TProtocolException issue (as per @ericemc3's original reproduction).

@mcrascal
Copy link

@carlopi thanks for looking into this.

I am also able to reproduce this on shell.duckdb.org @duckdb/duckdb-wasm@1.28.1-dev195.0, running chrome on windows.

This does not occur on chrome on mac.

  1. Clear browser data
  2. Visit shell.duckdb.org
  3. Successfully run the query FROM 'https://static.data.gouv.fr/resources/communes-2023-format-parquet/20240122-085355/communes2023.parquet' SELECT codgeo WHERE epci = '200039865' ;
  4. Refresh the page
  5. Run the query again - Invalid Error: TProtocolException: Invalid data
  6. Clear browser data
  7. Run the query again - success
Windows 11 10.0.22621les                                                                    
Chrome: 125.0.6422.77

@carlopi
Copy link
Collaborator

carlopi commented Jun 10, 2024

Hi all, we have developed a new duckdb-wasm version that allows to explicitly set whether to trust Content-Length informations from HEAD requests.

I have a hard time reproducing this on my setup, it would be amazing if anyone could run the original issue in 2 additional modes:

SET reliable_head_requests = false;
FROM 'https://static.data.gouv.fr/resources/communes-2023-format-parquet/20240122-085355/communes2023.parquet' 
SELECT codgeo WHERE epci = '200039865' ;

and

SET reliable_head_requests = true;
FROM 'https://static.data.gouv.fr/resources/communes-2023-format-parquet/20240122-085355/communes2023.parquet' 
SELECT codgeo WHERE epci = '200039865' ;

Changing the setting for reliable_head_requests changes slightly the logic that computes the length of a given resources, reordering the order in which requests are performed, from HEAD to GET requests.

This should move away from the behaviour that here was problematic.

I am experimenting with what behaviour should be set by default, input on whether this helps with this particular problem would be handy.

@ericemc3
Copy link
Author

Hi,
on Chrome and Edge Windows
Database: v1.0.0
Package: @duckdb/duckdb-wasm@1.28.1-dev216.0
Still the same issue with:

SET reliable_head_requests = true;
FROM 'https://static.data.gouv.fr/resources/communes-2023-format-parquet/20240122-085355/communes2023.parquet' 
SELECT codgeo WHERE epci = '200039865' ;

executed twice, OK. Then i reload the page, paste the same request again and get:
Invalid Error: TProtocolException: Invalid data

Is there another wasm version to test?

@carlopi
Copy link
Collaborator

carlopi commented Jun 10, 2024

@ericemc3
Copy link
Author

yes i tried both with the same outcome:
Invalid Error: TProtocolException: Invalid data

@massyn
Copy link

massyn commented Jul 3, 2024

I've been investigating an issue with ObservableHQ that relies on DuckDB that seems to have the same behaviour as listed in this issue. It does appear to be caching related. Is there any further information as to what might be causing this issue?

observablehq/framework#1470

@GuillaumeChretien
Copy link

Hi, same issue, +1 !

@bjyberg
Copy link

bjyberg commented Aug 2, 2024

I've posted workaround over on the related Observable Framework issue already, but maybe this will help someone here as well until the issue is fixed. Obviously there are downsides, but I have been able to work around the issue by cache busting on any parquet link if a Windows device is detected. See example here.

@GuillaumeChretienCerema

@bjyberg many thanks, it works very well ! hope future version will fix this...

@timothyhoward
Copy link

@carlopi Has there been any updates on this issue recently? I've been continuing to investigate where I can, even though we have a temporary fix through the caching flags. Thank you!

@eamcvey
Copy link

eamcvey commented Sep 27, 2024

@timothyhoward I'm experiencing this too, and it's become a late-in-the-game blocker for a dashboard I'm preparing for public release (all the early testers were Mac users and they had no problems). Since there doesn't seem to be a fix yet, I wonder if your caching flags approach is working smoothly? I can't tell from the previous posts whether it eliminates the problem entirely or if users have to reload once to get it to work. Any info and details you can provide about this would be great to hear, since it seems to be the only option at the moment.

@fboerman
Copy link

fboerman commented Sep 27, 2024 via email

@eamcvey
Copy link

eamcvey commented Sep 27, 2024

The more I contemplate this issue, the harder it is for me to understand why it isn't a problem with pretty much every use of DuckDB-Wasm that queries a file more than once. Does this just never work for Windows users on Chrome or Edge?

The statement on the DuckDB-Wasm main page "Duckdb-Wasm speaks Arrow fluently, reads Parquet, CSV and JSON files backed by Filesystem APIs or HTTP requests and has been tested with Chrome, Firefox, Safari and Node.js." certainly implies that this would have been tested. What am I missing? Does it impact a narrower context than I realize, and if so, what is that?

@timothyhoward
Copy link

@fboerman Unfortunately the Evidence patch only reimplements the original caching fix I suggested earlier, rather than rectifying the core of the issue which resides in duckdb-wasm or earlier in the line.

The new fix has also caused some unresolved issues with excessive bandwidth use, so hoping to get to the core of issue so the patch can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests