Skip to content

Commit

Permalink
Add back Node 22 also for Windows
Browse files Browse the repository at this point in the history
There was a compilation problem, that appears to have gone away in the mean time, probably node side
  • Loading branch information
carlopi committed May 24, 2024
1 parent d886b3e commit 6d0c9b6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/NodeJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
name: node.js Linux
runs-on: ubuntu-20.04
needs: set-up-npm
continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
continue-on-error: ${{ matrix.node == '12' || matrix.node == '14' || matrix.node == '16' || matrix.node == '17' }}
env:
TARGET_ARCH: ${{ matrix.target_arch }}
DUCKDB_NODE_BUILD_CACHE: 0
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
name: node.js OSX
runs-on: macos-14
needs: set-up-npm
continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
continue-on-error: ${{ matrix.node == '16' || matrix.node == '17' }}
strategy:
matrix:
target_arch: [ arm64 ]
Expand Down Expand Up @@ -245,13 +245,13 @@ jobs:
name: node.js Windows
runs-on: windows-latest
needs: set-up-npm
continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
continue-on-error: ${{ matrix.node == '16' || matrix.node == '17' }}
env:
npm_config_msvs_version: 2019

strategy:
matrix:
node: [ '16', '17', '18', '19', '20', '21']
node: [ '16', '17', '18', '19', '20', '21', '22']
isRelease:
- ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
exclude:
Expand Down

0 comments on commit 6d0c9b6

Please sign in to comment.