Fix #75: no longer throw when interpreting TINYINT(1) columns with non-0 or 1 values as booleans #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
MySQL doesn't have a proper boolean type - instead generally
TINYINT(1)orBIT(1)are used to represent booleans. Since #26 we support loading those columns as booleans.TINYINT(1)columns, however, can contain a wider range of values than a boolean (from-128to127). Previously we would throw an exception when a larger number was encountered. This PR modifies the behavior so that we instead interpret numbers<= 0as false, and numbers> 0as true.