Enable rs streaming and DB pinning for DuckLake #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a manual backport of the PR duckdb#258 to `v1.3-ossivalis` stable branch. The support for direct attach, was recently added to DuckLake in duckdb/ducklake#201. JDBC connection string example: ``` jdbc:duckdb:ducklake:postgres:postgresql://user:pwd@127.0.0.1:5432/lake1 ``` This change enables `jdbc_stream_results` and `jdbc_pin_db` options by default (unless they are specified by user) for DuckLake connections. Testing: test coverage pending as DuckLake is not yet available in the `main` barnch.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jun 20, 2025
With the changes introduced in duckdb#276 the `jdbc:duckdb:ducklake:...` URLs have the special handling: `jdbc_pin_db` and `jdbc_stream_results` options are applied to them automatically. This behaviour was supposed to be overridable with URL or `Properties` but by mistake incorrect method was used for override check. And as DuckLake is still not available in the `main` branch, there is no test coverage for this and the problem got into `1.3.1.0` update. Fixes: duckdb#283
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jun 24, 2025
With the changes introduced in duckdb#276 the `jdbc:duckdb:ducklake:...` URLs have the special handling: `jdbc_pin_db` and `jdbc_stream_results` options are applied to them automatically. This behaviour was supposed to be overridable with URL or `Properties` but by mistake incorrect method was used for override check. And as DuckLake is still not available in the `main` branch, there is no test coverage for this and the problem got into `1.3.1.0` update. Fixes: duckdb#283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of the PR #258 to
v1.3-ossivalisstable branch.The support for direct attach, was recently added to DuckLake in duckdb/ducklake#201. JDBC connection string example:
This change enables
jdbc_stream_resultsandjdbc_pin_dboptions by default (unless they are specified by user) for DuckLake connections.Testing: test coverage pending as DuckLake is not yet available in the
mainbarnch.