Merge pull request #90 from carlopi/main

Bump duckdb (absorbing patches), and bump extension-ci-tools
duckdb · Dec 17, 2024 · 88011ee · 88011ee
2 parents 8d70765 + 9d37bc9
commit 88011ee
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 13 deletions.
diff --git a/.github/workflows/MainDistributionPipeline.yml b/.github/workflows/MainDistributionPipeline.yml
@@ -14,20 +14,21 @@ concurrency:
 jobs:
   duckdb-stable-build:
     name: Build extension binaries
-    uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.1.2
+    uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
     with:
       extension_name: azure
-      duckdb_version: v1.1.2
-      ci_tools_version: v1.1.2
+      duckdb_version: main
+      ci_tools_version: main
       exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads;windows_amd64_rtools'
 
   duckdb-stable-deploy:
     name: Deploy extension binaries
     needs: duckdb-stable-build
-    uses: duckdb/extension-ci-tools/.github/workflows/_extension_deploy.yml@v1.1.2
+    uses: duckdb/extension-ci-tools/.github/workflows/_extension_deploy.yml@main
     secrets: inherit
     with:
       extension_name: azure
-      duckdb_version: v1.1.2
+      duckdb_version: main
+      ci_tools_version: main
       exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads;windows_amd64_rtools'
       deploy_latest: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
diff --git a/duckdb b/duckdb
diff --git a/extension-ci-tools b/extension-ci-tools
diff --git a/src/azure_blob_filesystem.cpp b/src/azure_blob_filesystem.cpp
@@ -10,7 +10,7 @@
 #include "duckdb/common/string_util.hpp"
 #include "duckdb/main/secret/secret.hpp"
 #include "duckdb/main/secret/secret_manager.hpp"
-#include "duckdb/function/scalar/string_functions.hpp"
+#include "duckdb/function/scalar/string_common.hpp"
 #include "duckdb/function/scalar_function.hpp"
 #include "duckdb/main/extension_util.hpp"
 #include "duckdb/main/client_data.hpp"
@@ -47,7 +47,7 @@ static bool Match(vector<string>::const_iterator key, vector<string>::const_iter
 			}
 			return false;
 		}
-		if (!LikeFun::Glob(key->data(), key->length(), pattern->data(), pattern->length())) {
+		if (!Glob(key->data(), key->length(), pattern->data(), pattern->length())) {
 			return false;
 		}
 		key++;

diff --git a/src/azure_dfs_filesystem.cpp b/src/azure_dfs_filesystem.cpp
@@ -3,7 +3,7 @@
 #include "duckdb/common/exception.hpp"
 #include "duckdb/common/helper.hpp"
 #include "duckdb/common/shared_ptr.hpp"
-#include "duckdb/function/scalar/string_functions.hpp"
+#include "duckdb/function/scalar/string_common.hpp"
 #include <algorithm>
 #include <azure/storage/blobs/blob_options.hpp>
 #include <azure/storage/common/storage_exception.hpp>
@@ -50,7 +50,7 @@ static void Walk(const Azure::Storage::Files::DataLake::DataLakeFileSystemClient
 		for (const auto &elt : res.Paths) {
 			if (elt.IsDirectory) {
 				if (!recursive) { // Only perform recursive call if we are not already processing recursive result
-					if (LikeFun::Glob(elt.Name.data(), elt.Name.length(), path_pattern.data(), end_match)) {
+					if (Glob(elt.Name.data(), elt.Name.length(), path_pattern.data(), end_match)) {
 						if (end_match >= path_pattern.length()) {
 							// Skip, no way there will be matches anymore
 							continue;
@@ -61,7 +61,7 @@ static void Walk(const Azure::Storage::Files::DataLake::DataLakeFileSystemClient
 				}
 			} else {
 				// File
-				if (LikeFun::Glob(elt.Name.data(), elt.Name.length(), path_pattern.data(), path_pattern.length())) {
+				if (Glob(elt.Name.data(), elt.Name.length(), path_pattern.data(), path_pattern.length())) {
 					out_result->push_back(elt.Name);
 				}
 			}

diff --git a/src/azure_filesystem.cpp b/src/azure_filesystem.cpp
@@ -21,7 +21,7 @@ void AzureContextState::QueryEnd() {
 
 AzureFileHandle::AzureFileHandle(AzureStorageFileSystem &fs, string path, FileOpenFlags flags,
                                  const AzureReadOptions &read_options)
-    : FileHandle(fs, std::move(path)), flags(flags),
+    : FileHandle(fs, std::move(path), flags), flags(flags),
       // File info
       length(0), last_modified(0),
       // Read info
+27 −3		.github/workflows/TestCITools.yml
+17 −10		.github/workflows/_extension_deploy.yml
+54 −70		.github/workflows/_extension_distribution.yml
+3 −2		README.md
+258 −0		makefiles/c_api_extensions/base.Makefile
+129 −0		makefiles/c_api_extensions/c_cpp.Makefile
+47 −0		makefiles/c_api_extensions/rust.Makefile
+31 −7		makefiles/duckdb_extension.Makefile
+44 −6		scripts/append_extension_metadata.py
+45 −0		scripts/configure_helper.py