Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keep_open: true the default setting for dbt-duckdb going forward #502

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Make keep_open: true the default setting for dbt-duckdb going forward #502

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cf0d2b
Make keep_open: true the default setting for dbt-duckdb going forward
jwills Jan 21, 2025
36d8b44
Curious about some test updates here
jwills Jan 21, 2025
407c0dc
Okay that does not seem keep_open-related, good
jwills Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Okay that does not seem keep_open-related, good
  • Loading branch information
@jwills
jwills committed Jan 21, 2025
commit 407c0dcab616e4167e757a9cf8df5c6c08f29792
1 change: 0 additions & 1 deletion tests/functional/plugins/test_delta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ def profiles_config_update(self, dbt_profile_target):
"dev": {
"type": "duckdb",
"path": dbt_profile_target.get("path", ":memory:"),
"keep_open": False,
"plugins": plugins,
}
},
Expand Down
Loading