forked from facebook/react
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
It would actually have detected the issue facebook#18657. It found the following counterexample: ``` [Scheduler` -> [task#2] sequence::Scheduling "8" with priority 3 resolved -> [task#1] promise::Request for "447b0ed" resolved with value "resolved 447b0ed!"`,"447b0ed",[{"priority":3,"text":"8"}],<function :: ["447b0ed"] => true, ["8"] => true>] ``` Reproduced by https://codesandbox.io/s/strange-frost-d4ujl?file=/src/App.js Related to facebook#18669
- Loading branch information
Showing
4 changed files
with
160 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
packages/react-reconciler/src/__tests__/ReactSuspense-test.property.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| let React; | ||
| let ReactFeatureFlags; | ||
| let ReactNoop; | ||
| let Scheduler; | ||
| let Suspense; | ||
|
|
||
| const fc = require('fast-check'); | ||
|
|
||
| const beforeEachAction = () => { | ||
| jest.resetModules(); | ||
| ReactFeatureFlags = require('shared/ReactFeatureFlags'); | ||
| ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false; | ||
| ReactFeatureFlags.enableSuspenseServerRenderer = true; | ||
| React = require('react'); | ||
| ReactNoop = require('react-noop-renderer'); | ||
| Scheduler = require('scheduler'); | ||
| Suspense = React.Suspense; | ||
| }; | ||
|
|
||
| function flushAndYieldScheduler() { | ||
| Scheduler.unstable_flushAllWithoutAsserting(); | ||
| Scheduler.unstable_clearYields(); | ||
| } | ||
|
|
||
| function Text({text}) { | ||
| return <span>{text}</span>; | ||
| } | ||
|
|
||
| function AsyncText({text, readOrThrow}) { | ||
| readOrThrow(text); | ||
| return <span>{text}</span>; | ||
| } | ||
|
|
||
| describe('ReactSuspense', () => { | ||
| beforeEach(beforeEachAction); | ||
|
|
||
| it('render based on the latest state', async () => { | ||
| await fc.assert( | ||
| fc | ||
| .asyncProperty( | ||
| // Scheduler able to re-order operations | ||
| fc.scheduler(), | ||
| // The initial text defined in the App component | ||
| fc.stringOf(fc.hexa()), | ||
| // Array of updates with the associated priority | ||
| fc.array( | ||
| fc.record({ | ||
| // Priority of the task | ||
| priority: fc.constantFrom( | ||
| Scheduler.unstable_ImmediatePriority, | ||
| Scheduler.unstable_UserBlockingPriority, | ||
| Scheduler.unstable_NormalPriority, | ||
| Scheduler.unstable_IdlePriority, | ||
| Scheduler.unstable_LowPriority, | ||
| ), | ||
| // Value to set for text | ||
| text: fc.stringOf(fc.hexa()), | ||
| }), | ||
| ), | ||
| // The code under test | ||
| async (s, initialText, textUpdates) => { | ||
| // We simulate a cache: string -> Promise | ||
| // It may contain successes and rejections | ||
| const cache = new Map(); | ||
| const readOrThrow = text => { | ||
| if (cache.has(text)) { | ||
| // The text has already been queried | ||
| const {promise, resolvedWith} = cache.get(text); | ||
| // Not resolved yet? | ||
| if (resolvedWith === null) throw promise; | ||
| // Success | ||
| return text; | ||
| } else { | ||
| // Not yet queried | ||
| const promise = s.schedule( | ||
| Promise.resolve(), | ||
| `Request for ${JSON.stringify(text)}`, | ||
| ); | ||
| const cachedValue = {promise, resolvedWith: null}; | ||
| promise.then(success => (cachedValue.resolvedWith = {success})); | ||
| cache.set(text, cachedValue); | ||
| throw promise; | ||
| } | ||
| }; | ||
|
|
||
| let setText; | ||
| function App() { | ||
| const [text, _setText] = React.useState(initialText); | ||
| setText = _setText; | ||
| return <AsyncText text={text} readOrThrow={readOrThrow} />; | ||
| } | ||
|
|
||
| // Initial render | ||
| ReactNoop.render( | ||
| <Suspense fallback={<Text text="Loading..." />}> | ||
| <App /> | ||
| </Suspense>, | ||
| ); | ||
| flushAndYieldScheduler(); | ||
| expect(ReactNoop).toMatchRenderedOutput(<span>Loading...</span>); | ||
|
|
||
| // Schedule updates into the scheduler | ||
| // Updates will not be reordered | ||
| // BUT promises that they may trigger may be scheduled in-between | ||
| s.scheduleSequence( | ||
| textUpdates.map(update => { | ||
| return { | ||
| label: `Scheduling ${JSON.stringify( | ||
| update.text, | ||
| )} with priority ${update.priority}`, | ||
| builder: async () => | ||
| Scheduler.unstable_runWithPriority(update.priority, () => { | ||
| setText(update.text); | ||
| }), | ||
| }; | ||
| }), | ||
| ); | ||
|
|
||
| // Exhaust the queue of scheduled tasks | ||
| while (s.count() !== 0) { | ||
| await ReactNoop.act(async () => { | ||
| await s.waitOne(); | ||
| flushAndYieldScheduler(); | ||
| }); | ||
| } | ||
|
|
||
| // Check the final value is the expected one | ||
| const lastText = | ||
| textUpdates.length > 0 | ||
| ? textUpdates[textUpdates.length - 1].text | ||
| : initialText; | ||
| expect(ReactNoop).toMatchRenderedOutput(<span>{lastText}</span>); | ||
| }, | ||
| ) | ||
| .beforeEach(beforeEachAction), | ||
| ); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters