Skip to content

Partner rejection updates - #3671

Merged
steven-tey merged 2 commits into
mainfrom
rejection-tooltip
Mar 31, 2026
Merged

Partner rejection updates#3671
steven-tey merged 2 commits into
mainfrom
rejection-tooltip

Conversation

@marcusljf

@marcusljf marcusljf commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator
  • Reduced max characters of the program application rejection to from 5000 to 500
  • Updated the tooltip styling to be closer to the designs
  • Ensured formatting carries through from note -> tooltip -> email
CleanShot 2026-03-31 at 12 18 58@2x

Summary by CodeRabbit

  • Validation Changes

    • Reduced maximum character limit for partner rejection notes from 5000 to 500 characters.
  • UI/UX Improvements

    • Added a real-time character counter to the rejection notes field and enforced the shorter limit.
    • Improved rejected-application details layout with tighter spacing, adjusted iconography, and refined typography for clearer hierarchy.

@vercel

vercel Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Ready Ready Preview Mar 31, 2026 7:54pm

Request Review

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Reduces the maximum character limit for partner rejection notes from 5000 to 500 and updates the corresponding UI components. Adds a character counter display in the rejection modal and refreshes tooltip styling and layout in the partner program card.

Changes

Cohort / File(s) Summary
Schema Configuration
apps/web/lib/zod/schemas/partners.ts
Updated PROGRAM_APPLICATION_REJECTION_NOTE_MAX_LENGTH constant from 5000 to 500 characters, tightening the validation constraint for rejection note fields.
Rejection Modal UI
apps/web/ui/modals/reject-partner-application-modal.tsx
Added a character counter display next to the "Additional notes (optional)" label showing current length against the configured maximum; textarea still enforces maxLength binding.
Partner Card Tooltip
apps/web/ui/partners/program-card.tsx
Refactored rejection tooltip layout with updated spacing (gap-2 p-3 pb-4), row styling (flex w-full items-start gap-2), typography adjustments (label: text-[10px] font-bold; default value: text-xs), icon replacement (CircleInfoCircleQuestion), and reordered rows with "Reviewed" at top.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

I nibbled lines and trimmed the note,
From five thousand down to five-oh-oh — so remote,
A counter now ticks, neat and spry,
Tooltips polished, styled to fly,
Hooray — a rabbit's tidy code hop! 🐇✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title "Partner rejection updates" is vague and generic, using non-specific language that doesn't convey the meaningful details of the changeset (max character limit reduction, tooltip styling, and formatting improvements). Consider using a more descriptive title such as "Reduce rejection note limit to 500 chars and update tooltip styling" to better communicate the primary changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rejection-tooltip

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
apps/web/ui/partners/program-card.tsx (1)

34-52: ⚠️ Potential issue | 🔴 Critical

font-reg is not a valid Tailwind utility and will be silently ignored.

The class font-reg used on lines 45 and 93 is not defined in the Tailwind configuration. Standard Tailwind only provides font-thin through font-black. Since this utility doesn't exist, the font-weight styling will be lost. Check if this should be font-normal (400 weight) or if a custom font-reg utility needs to be added to the Tailwind config.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/web/ui/partners/program-card.tsx` around lines 34 - 52, The component
uses a non-existent Tailwind utility "font-reg" (in the value paragraph class)
so the font-weight is silently ignored; update the class on the element that
renders {value} (and any other occurrences of "font-reg" in this file/component)
to a valid utility like "font-normal" or change to a configured custom utility
by adding "font-reg" to the Tailwind config; locate the class string inside the
JSX (the valueClassName fallback and any hardcoded classnames around the {value}
render) and replace "font-reg" with "font-normal" unless you intentionally add
"font-reg" to your Tailwind theme.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@apps/web/ui/partners/program-card.tsx`:
- Around line 34-52: The component uses a non-existent Tailwind utility
"font-reg" (in the value paragraph class) so the font-weight is silently
ignored; update the class on the element that renders {value} (and any other
occurrences of "font-reg" in this file/component) to a valid utility like
"font-normal" or change to a configured custom utility by adding "font-reg" to
the Tailwind config; locate the class string inside the JSX (the valueClassName
fallback and any hardcoded classnames around the {value} render) and replace
"font-reg" with "font-normal" unless you intentionally add "font-reg" to your
Tailwind theme.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb7d9441-9231-43f9-bf08-236e8bc711bc

📥 Commits

Reviewing files that changed from the base of the PR and between 4b050e2 and d9cbda9.

📒 Files selected for processing (3)
  • apps/web/lib/zod/schemas/partners.ts
  • apps/web/ui/modals/reject-partner-application-modal.tsx
  • apps/web/ui/partners/program-card.tsx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/web/ui/partners/program-card.tsx`:
- Line 93: Replace the typo in the class string used for the ProgramCard
component: change the valueClassName prop value that currently contains
"font-reg" to "font-regular" so it matches the project's established utility
classname pattern (look for valueClassName="... font-reg ..." in
program-card.tsx and update to "font-regular").
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f2587232-c4b7-4e3e-828f-25e260e84350

📥 Commits

Reviewing files that changed from the base of the PR and between d9cbda9 and 6b5a0c7.

📒 Files selected for processing (1)
  • apps/web/ui/partners/program-card.tsx

Comment thread apps/web/ui/partners/program-card.tsx
@steven-tey
steven-tey merged commit d3e0687 into main Mar 31, 2026
10 of 11 checks passed
@steven-tey
steven-tey deleted the rejection-tooltip branch March 31, 2026 21:19
@coderabbitai coderabbitai Bot mentioned this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants