-
Notifications
You must be signed in to change notification settings - Fork 2.8k
style: use text-violet-500 instead of hardcoded hex color #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace hardcoded `text-[#8B5CF6]` with `text-violet-500` in chart components for consistency. The tooltip legends in these same components already use `bg-violet-500`, so this aligns the codebase. Files changed: - overview-chart.tsx - analytics-timeseries-chart.tsx 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@dylantarre is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughHardcoded hex color values ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-10-15T01:05:43.266ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@dylantarre Great catch, thank you! |
Summary
text-[#8B5CF6]withtext-violet-500in chart componentsbg-violet-500in tooltip legends within the same componentsContext
Both
overview-chart.tsxandanalytics-timeseries-chart.tsxuse the same violet color in two places:colorClassName: "text-[#8B5CF6]"(hardcoded)bg-violet-500(proper token)Since
#8B5CF6is exactly Tailwind'sviolet-500, this PR makes the codebase consistent.Files changed
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/overview-chart.tsxapps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-timeseries-chart.tsxCloses #3312
Found using Buoy - design system drift detection
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.