Releasing v1.0.1 #117
Merged
Releasing v1.0.1 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request dtscalibration#116 from bdestombe/master
Signed-off-by: Bas des Tombe <bdestombe@gmail.com>
There was a problem hiding this comment.
Hoi Bas,
There were a few more changes since 1.0. Perhaps it's also good to list them as bugfixes vs new features. I had already made this list of all changes up to your PR.;
New features
- st_var can now be array-like. The array-like can vary in x or time, or both.
- When converting from a xr.Dataset to a DataStore object, the attributes are now transfered over
- Added 'verbose' kwarg to shift_double_ended utility function to silence the console output
Bug fixes
- If the '_sections' attribute is missing from a DataStore object it is automagically re-added.
- Assert that stokes variances are passed when running a double-ended WLS calibration
- Added check for NaN/inf values in wls_sparse solver to avoid unclear error messages
- Before calibration, the values of the used reference temperatures are checked if they are valid (float dtype, no NaN/inf values, correct time dimension)
|
@BSchilperoort Sorry, missed your comment. Made your suggested changes to the CHANGELOG.rst which will appear in v1.0.2 |
|
Well I only posted it after you already merged the PR haha. Perhaps we should make it a habit to change the changelog with every PR? I had this list made for some time, but didn't think of adding it to the changelog already. |
|
Yes, but I merged the PR rather quick, giving you no time to post any feedback ;) Your idea sounds more than reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.