Improve 404 error message for clarity

[dheles]

No description provided.

[mark-cooper]

@dheles how about?

raise Error, "No results found for request, returns #{response.status} - #{response.body}"

From a client perspective it's unusual to put itself (url) into the message, I'd expect that to come from the context, so wherever the client is being called from should log what it's doing.

[dheles]

Well I decided to add this when I was running

$ bundle exec ruby dspace-reporter.rb NAJCulture najculture.org

And it took me a while to figure out the script was inferring part of the rest_url, but that it was failing because i hadn't provided the "www." Seeing the url that's returning 404 helped me see the problem. IMO, it doesn't cost anything to have an error message provide extra info (even if you think the user should know that info already) and that often helps the lightbulb go on sooner.