Make error_generic_member_access compatible with -Dwarnings #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
reviewed
Aug 20, 2025
| .arg("--crate-type=lib") | ||
| .arg("--cap-lints=allow") | ||
| .arg("--emit=dep-info,metadata") | ||
| .arg("--cap-lints=allow") |
There was a problem hiding this comment.
Out of curiosity: Isn't this duplicated now because --cap-lints=allow is already being set in line 121? Same for dtolnay/proc-macro2#515.
There was a problem hiding this comment.
Yes, good call. I missed that the same flags were already present but just ordered differently compared to the anyhow build script. I'll revert these.
jimsynz
pushed a commit
to jimsynz/outrun
that referenced
this pull request
Oct 13, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [thiserror](https://github.com/dtolnay/thiserror) | dependencies | major | `1.0` -> `2.0` | --- ### Release Notes <details> <summary>dtolnay/thiserror (thiserror)</summary> ### [`v2.0.17`](https://github.com/dtolnay/thiserror/releases/tag/2.0.17) [Compare Source](dtolnay/thiserror@2.0.16...2.0.17) - Use differently named \_\_private module per patch release ([#​434](dtolnay/thiserror#434)) ### [`v2.0.16`](https://github.com/dtolnay/thiserror/releases/tag/2.0.16) [Compare Source](dtolnay/thiserror@2.0.15...2.0.16) - Add to "no-std" crates.io category ([#​429](dtolnay/thiserror#429)) ### [`v2.0.15`](https://github.com/dtolnay/thiserror/releases/tag/2.0.15) [Compare Source](dtolnay/thiserror@2.0.14...2.0.15) - Prevent `Error::provide` API becoming unavailable from a future new compiler lint ([#​427](dtolnay/thiserror#427)) ### [`v2.0.14`](https://github.com/dtolnay/thiserror/releases/tag/2.0.14) [Compare Source](dtolnay/thiserror@2.0.13...2.0.14) - Allow build-script cleanup failure with NFSv3 output directory to be non-fatal ([#​426](dtolnay/thiserror#426)) ### [`v2.0.13`](https://github.com/dtolnay/thiserror/releases/tag/2.0.13) [Compare Source](dtolnay/thiserror@2.0.12...2.0.13) - Documentation improvements ### [`v2.0.12`](https://github.com/dtolnay/thiserror/releases/tag/2.0.12) [Compare Source](dtolnay/thiserror@2.0.11...2.0.12) - Prevent elidable\_lifetime\_names pedantic clippy lint in generated impl ([#​413](dtolnay/thiserror#413)) ### [`v2.0.11`](https://github.com/dtolnay/thiserror/releases/tag/2.0.11) [Compare Source](dtolnay/thiserror@2.0.10...2.0.11) - Add feature gate to tests that use std ([#​409](dtolnay/thiserror#409), [#​410](dtolnay/thiserror#410), thanks [@​Maytha8](https://github.com/Maytha8)) ### [`v2.0.10`](https://github.com/dtolnay/thiserror/releases/tag/2.0.10) [Compare Source](dtolnay/thiserror@2.0.9...2.0.10) - Support errors containing a generic type parameter's associated type in a field ([#​408](dtolnay/thiserror#408)) ### [`v2.0.9`](https://github.com/dtolnay/thiserror/releases/tag/2.0.9) [Compare Source](dtolnay/thiserror@2.0.8...2.0.9) - Work around `missing_inline_in_public_items` clippy restriction being triggered in macro-generated code ([#​404](dtolnay/thiserror#404)) ### [`v2.0.8`](https://github.com/dtolnay/thiserror/releases/tag/2.0.8) [Compare Source](dtolnay/thiserror@2.0.7...2.0.8) - Improve support for macro-generated `derive(Error)` call sites ([#​399](dtolnay/thiserror#399)) ### [`v2.0.7`](https://github.com/dtolnay/thiserror/releases/tag/2.0.7) [Compare Source](dtolnay/thiserror@2.0.6...2.0.7) - Work around conflict with #\[deny(clippy::allow\_attributes)] ([#​397](dtolnay/thiserror#397), thanks [@​zertosh](https://github.com/zertosh)) ### [`v2.0.6`](https://github.com/dtolnay/thiserror/releases/tag/2.0.6) [Compare Source](dtolnay/thiserror@2.0.5...2.0.6) - Suppress deprecation warning on generated From impls ([#​396](dtolnay/thiserror#396)) ### [`v2.0.5`](https://github.com/dtolnay/thiserror/releases/tag/2.0.5) [Compare Source](dtolnay/thiserror@2.0.4...2.0.5) - Prevent deprecation warning on generated impl for deprecated type ([#​394](dtolnay/thiserror#394)) ### [`v2.0.4`](https://github.com/dtolnay/thiserror/releases/tag/2.0.4) [Compare Source](dtolnay/thiserror@2.0.3...2.0.4) - Eliminate needless\_lifetimes clippy lint in generated `From` impls ([#​391](dtolnay/thiserror#391), thanks [@​matt-phylum](https://github.com/matt-phylum)) ### [`v2.0.3`](https://github.com/dtolnay/thiserror/releases/tag/2.0.3) [Compare Source](dtolnay/thiserror@2.0.2...2.0.3) - Support the same Path field being repeated in both Debug and Display representation in error message ([#​383](dtolnay/thiserror#383)) - Improve error message when a format trait used in error message is not implemented by some field ([#​384](dtolnay/thiserror#384)) ### [`v2.0.2`](https://github.com/dtolnay/thiserror/releases/tag/2.0.2) [Compare Source](dtolnay/thiserror@2.0.1...2.0.2) - Fix hang on invalid input inside #\[error(...)] attribute ([#​382](dtolnay/thiserror#382)) ### [`v2.0.1`](https://github.com/dtolnay/thiserror/releases/tag/2.0.1) [Compare Source](dtolnay/thiserror@2.0.0...2.0.1) - Support errors that contain a dynamically sized final field ([#​375](dtolnay/thiserror#375)) - Improve inference of trait bounds for fields that are interpolated multiple times in an error message ([#​377](dtolnay/thiserror#377)) ### [`v2.0.0`](https://github.com/dtolnay/thiserror/releases/tag/2.0.0) [Compare Source](dtolnay/thiserror@1.0.69...2.0.0) ##### Breaking changes - Referencing keyword-named fields by a raw identifier like `{r#type}` inside a format string is no longer accepted; simply use the unraw name like `{type}` ([#​347](dtolnay/thiserror#347)) This aligns thiserror with the standard library's formatting macros, which gained support for implicit argument capture later than the release of this feature in thiserror 1.x. ```rust #[derive(Error, Debug)] #[error("... {type} ...")] // Before: {r#type} pub struct Error { pub r#type: Type, } ``` - Trait bounds are no longer inferred on fields whose value is shadowed by an explicit named argument in a format message ([#​345](dtolnay/thiserror#345)) ```rust // Before: impl<T: Octal> Display for Error<T> // After: impl<T> Display for Error<T> #[derive(Error, Debug)] #[error("{thing:o}", thing = "...")] pub struct Error<T> { thing: T, } ``` - Tuple structs and tuple variants can no longer use numerical `{0}` `{1}` access at the same time as supplying extra positional arguments for a format message, as this makes it ambiguous whether the number refers to a tuple field vs a different positional arg ([#​354](dtolnay/thiserror#354)) ```rust #[derive(Error, Debug)] #[error("ambiguous: {0} {}", $N)] // ^^^ Not allowed, use #[error("... {0} {n}", n = $N)] pub struct TupleError(i32); ``` - Code containing invocations of thiserror's `derive(Error)` must now have a direct dependency on the `thiserror` crate regardless of the error data structure's contents ([#​368](dtolnay/thiserror#368), [#​369](dtolnay/thiserror#369), [#​370](dtolnay/thiserror#370), [#​372](dtolnay/thiserror#372)) ##### Features - Support disabling thiserror's standard library dependency by disabling the default "std" Cargo feature: `thiserror = { version = "2", default-features = false }` ([#​373](dtolnay/thiserror#373)) - Support using `r#source` as field name to opt out of a field named "source" being treated as an error's `Error::source()` ([#​350](dtolnay/thiserror#350)) ```rust #[derive(Error, Debug)] #[error("{source} ==> {destination}")] pub struct Error { r#source: char, destination: char, } let error = Error { source: 'S', destination: 'D' }; ``` - Infinite recursion in a generated Display impl now produces an `unconditional_recursion` warning ([#​359](dtolnay/thiserror#359)) ```rust #[derive(Error, Debug)] #[error("??? {self}")] pub struct Error; ``` - A new attribute `#[error(fmt = path::to::myfmt)]` can be used to write formatting logic for an enum variant out-of-line ([#​367](dtolnay/thiserror#367)) ```rust #[derive(Error, Debug)] pub enum Error { #[error(fmt = demo_fmt)] Demo { code: u16, message: Option<String> }, } fn demo_fmt(code: &u16, message: &Option<String>, formatter: &mut fmt::Formatter) -> fmt::Result { write!(formatter, "{code}")?; if let Some(msg) = message { write!(formatter, " - {msg}")?; } Ok(()) } ``` - Enums with an enum-level format message are now able to have individual variants that are `transparent` to supersede the enum-level message ([#​366](dtolnay/thiserror#366)) ```rust #[derive(Error, Debug)] #[error("my error {0}")] pub enum Error { Json(#[from] serde_json::Error), Yaml(#[from] serde_yaml::Error), #[error(transparent)] Other(#[from] anyhow::Error), } ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland, Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) in timezone Pacific/Auckland. 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNy4yIiwidXBkYXRlZEluVmVyIjoiNDEuMTMxLjkiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInJlbm92YXRlIl19--> Reviewed-on: https://harton.dev/outrun/outrun/pulls/81 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from dtolnay/anyhow#354.