Support parsing half-open ranges in patterns.#128
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Apr 30, 2017
Arnavion:half-open-pat
Merged
Support parsing half-open ranges in patterns.#128dtolnay merged 1 commit intodtolnay:masterfrom Arnavion:half-open-pat
dtolnay merged 1 commit intodtolnay:masterfrom
Arnavion:half-open-pat
Conversation
Owner
|
Looks good to me but hmm, any idea why libsyntax uses two different enums for Expr ranges vs Pat ranges? pub enum ExprKind {
/* ... */
/// A range (`1..2`, `1..`, `..2`, `1...2`, `1...`, `...2`)
Range(Option<P<Expr>>, Option<P<Expr>>, RangeLimits),
}
/// Limit types of a range (inclusive or exclusive)
pub enum RangeLimits {
/// Inclusive at the beginning, exclusive at the end
HalfOpen,
/// Inclusive at the beginning and end
Closed,
}
pub enum PatKind {
/* ... */
/// A range pattern, e.g. `1...2` or `1..2`
Range(P<Expr>, P<Expr>, RangeEnd),
}
pub enum RangeEnd {
Included,
Excluded,
} |
Contributor
Author
|
Nothing that's obvious from the commit message or PR discussion. @oli-obk ? |
|
I think the answer is rather obvious: I didn't know about RangeLimits... XD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117