Add feature force-fallback #219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
requested changes
May 1, 2020
There was a problem hiding this comment.
I would prefer not to accept this because it breaks error reporting of unrelated macros in any codebase that pulls in your library.
Instead we can consider factoring the fallback implementation in a way that can be published under a separate crate name, kind of like how https://crates.io/crates/serde_derive_internals is published from inside the serde_derive internals.
|
I use it within syn. So, should we implement some solution to force use the fallback in |
|
Could you confirm that #220 resolves your use case? |
|
Yes, it would be solved. Thanks!! |
Repository owner
locked and limited conversation to collaborators
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216