Skip to content

Namespace forward declarations #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 2 commits into from
Nov 1, 2020
Merged

Namespace forward declarations #392

dtolnay merged 2 commits into from
Nov 1, 2020

Conversation

@adetaylor
Copy link
Collaborator

@adetaylor adetaylor commented Nov 1, 2020

Fixes #386.

@adetaylor
Test for namespace order sensitivity.
9238b70
@adetaylor
Fix namespace forward declarations.
f921362 
This fixes the case where a lexicographically early namespace
has a reference to a type in a lexicographically later namespace.
dtolnay
dtolnay approved these changes Nov 1, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 0aa9c77 into dtolnay:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Order sensitivity across namespaces

2 participants

@adetaylor @dtolnay