optional macro parameter for adding Sync marker to returned Future type #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes dtolnay#77 Sponsored-by: 49nord GmbH
Author
|
What is the maintainers' opinion on this PR? Despite of the discussions in #77, I believe that it would be the most pragmatic approach to merge the feature implemented by this PR until the larger Rust community converges to how we should deal with |
|
Hi. Is there any option to merge it? |
dtolnay
reviewed
Dec 1, 2022
Owner
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
It looks like the branch that this PR was created from has commits that were not intended to be included in this PR, so this is not in a mergeable state.
I see there is another Sync-related PR open (#216) so I'll close this one in favor of that. Thanks anyway!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77
Sponsored-by: 49nord GmbH