Skip to content

Look for args set to null by a C library #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

Look for args set to null by a C library #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,15 @@ mod r#impl {

// We count on the OS to provide argv for which argv + argc does not
// overflow.
let end = unsafe { argv.offset(argc as isize) };
let max_end = unsafe { argv.offset(argc as isize) };

// Stop at the first null arg. Some C command-line parsers (including
// GTK's GLib and Qt's QCommandLineParser) erase already handled
// arguments from argv and leave null entries at the end.
let mut end = argv;
while end < max_end && !unsafe { *end }.is_null() {
end = unsafe { end.add(1) };
}

Iter { next: argv, end }
}
Expand Down
Loading