Permit autocomplete options #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great @milesj ! Thanks à lot ! Do you think it can be shipped on a minor or patch version ? |
|
Not sure. I don't have access to publish. |
|
Ah ok 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far user defined
autocompletefunction will not be called when trying to complete the arguments of a given options.In case of
allowUnknownOptions, it would be useful that the autocomplete function takes care of the flags completion.This is the need I have for building vorpal-shell to have in cli completion of options.
Maybe other design option can be considered such as a property
handlesOptionin theautocompleteoption along with the functiondata. I'm open to that :)