Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: test PR82478 #257

Closed
wants to merge 2 commits into from
Closed

pre-commit: test PR82478 #257

wants to merge 2 commits into from

Conversation

dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Feb 22, 2024

@github-actions GitHub Actions
Copy link
Contributor

baseline: llvm/llvm-project@73c646a
patch: llvm/llvm-project#82478
sha256: b9c7a6b190355446d9aff55b6c576baa5b21e10452c1688e71320dc1dd5a2b03
commit: 2b78b4c
281 files changed, 42430 insertions(+), 42309 deletions(-)
2b78b4c pre-commit: Update
bench/arrow/optimized/bignum.cc.ll
bench/arrow/optimized/bitmap_ops.cc.ll
bench/arrow/optimized/compare.cc.ll
bench/arrow/optimized/decimal.cc.ll
bench/arrow/optimized/io_util.cc.ll
bench/arrow/optimized/value_parsing.cc.ll
bench/assimp/optimized/glTF2Exporter.cpp.ll
bench/assimp/optimized/zip.c.ll
bench/cpython/optimized/_cursesmodule.ll
bench/cpython/optimized/_elementtree.ll
bench/cpython/optimized/iobase.ll
bench/cpython/optimized/obmalloc.ll
bench/cpython/optimized/zlibmodule.ll
bench/curl/optimized/libcurl_la-mprintf.ll
bench/curl/optimized/libcurl_la-select.ll
bench/cvc5/optimized/SimpSolver.cc.ll
bench/double_conversion/optimized/bignum.cc.ll
bench/eastl/optimized/BenchmarkList.cpp.ll
bench/eastl/optimized/EASprintf.cpp.ll
bench/eastl/optimized/EASprintfOrdered.cpp.ll
bench/eastl/optimized/EAString.cpp.ll
bench/eastl/optimized/TestExtra.cpp.ll
bench/eastl/optimized/TestFixedMap.cpp.ll
bench/eastl/optimized/TestFixedSet.cpp.ll
bench/eastl/optimized/TestMap.cpp.ll
bench/eastl/optimized/TestSet.cpp.ll
bench/eastl/optimized/TestVectorMap.cpp.ll
bench/eastl/optimized/TestVectorSet.cpp.ll
bench/entt/optimized/meta_container.cpp.ll
bench/flatbuffers/optimized/idl_gen_cpp.cpp.ll
bench/fmt/optimized/chrono-test.cc.ll
bench/fmt/optimized/compile-test.cc.ll
bench/fmt/optimized/enforce-checks-test.cc.ll
bench/fmt/optimized/format-impl-test.cc.ll
bench/fmt/optimized/format.cc.ll
bench/fmt/optimized/gtest-extra.cc.ll
bench/fmt/optimized/header-only-test.cc.ll
bench/fmt/optimized/os.cc.ll
bench/fmt/optimized/ranges-test.cc.ll
bench/fmt/optimized/std-test.cc.ll
bench/fmt/optimized/unicode-test.cc.ll
bench/fmt/optimized/util.cc.ll
bench/folly/optimized/JSONSchema.cpp.ll
bench/git/optimized/date.ll
bench/git/optimized/transport.ll
bench/git/optimized/xemit.ll
bench/grpc/optimized/timeout_encoding.cc.ll
bench/hermes/optimized/APFloat.cpp.ll
bench/hermes/optimized/zip.c.ll
bench/hyperscan/optimized/fdr_compile.cpp.ll
bench/hyperscan/optimized/rose_build_bytecode.cpp.ll
bench/hyperscan/optimized/rose_build_long_lit.cpp.ll
bench/hyperscan/optimized/rose_build_merge.cpp.ll
bench/icu/optimized/collationdatabuilder.ll
bench/icu/optimized/double-conversion-bignum.ll
bench/icu/optimized/inputext.ll
bench/icu/optimized/locid.ll
bench/icu/optimized/locutil.ll
bench/icu/optimized/msgfmt.ll
bench/icu/optimized/nfrule.ll
bench/icu/optimized/number_decimalquantity.ll
bench/icu/optimized/number_mapper.ll
bench/icu/optimized/plurfmt.ll
bench/icu/optimized/putil.ll
bench/icu/optimized/servlk.ll
bench/icu/optimized/unistr.ll
bench/icu/optimized/ustrtrns.ll
bench/icu/optimized/utf_impl.ll
bench/imgui/optimized/imgui.cpp.ll
bench/imgui/optimized/imgui_widgets.cpp.ll
bench/kcp/optimized/ikcp.ll
bench/libevent/optimized/bufferevent_ssl.c.ll
bench/libevent/optimized/evdns.c.ll
bench/libquic/optimized/base64_bio.c.ll
bench/libquic/optimized/e_rc2.c.ll
bench/libquic/optimized/pem_lib.c.ll
bench/llama.cpp/optimized/ggml-quants.c.ll
bench/llama.cpp/optimized/llama.cpp.ll
bench/lua/optimized/lstrlib.ll
bench/luajit/optimized/lib_string.ll
bench/luajit/optimized/lib_string_dyn.ll
bench/luajit/optimized/lj_strscan.ll
bench/luajit/optimized/lj_strscan_dyn.ll
bench/luajit/optimized/minilua.ll
bench/lz4/optimized/lz4hc.c.ll
bench/meshoptimizer/optimized/vertexfilter.cpp.ll
bench/mold/optimized/perf.cc.ll
bench/nghttp2/optimized/nghttp2_session.c.ll
bench/nlohmann_json/optimized/unit-bson.cpp.ll
bench/nlohmann_json/optimized/unit-cbor.cpp.ll
bench/nlohmann_json/optimized/unit-msgpack.cpp.ll
bench/ocio/optimized/ConfigUtils.cpp.ll
bench/oiio/optimized/CineonHeader.cpp.ll
bench/oiio/optimized/argparse.cpp.ll
bench/oiio/optimized/benchmark.cpp.ll
bench/oiio/optimized/bmpinput.cpp.ll
bench/oiio/optimized/bmpoutput.cpp.ll
bench/oiio/optimized/cineoninput.cpp.ll
bench/oiio/optimized/color_ocio.cpp.ll

dtcxzyw
dtcxzyw commented Feb 22, 2024
View reviewed changes
bench/pbrt-v4/optimized/stbimage.cpp.ll
%32 = tail call i32 @llvm.smax.i32(i32 %shr63, i32 0)
%b.0 = tail call i32 @llvm.smin.i32(i32 %32, i32 255)
%conv84 = trunc i32 %r.0 to i8
%31 = tail call i32 @llvm.umin.i32(i32 %30, i32 255)
Copy link
Owner Author

@dtcxzyw dtcxzyw Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks signed clamp idiom.

dtcxzyw
dtcxzyw commented Feb 22, 2024
View reviewed changes
bench/pbrt-v4/optimized/shapes.cpp.ll
@@ -7210,21 +7210,22 @@ if.then133: ; preds = %for.end
%div = fdiv float %mul142, %mul143
%call144 = call noundef i32 @_ZN4pbrt7Log2IntEf(float noundef %div)
%div145 = sdiv i32 %call144, 2
%high.val.i = call i32 @llvm.smin.i32(i32 %div145, i32 10)
%retval.0.i = call i32 @llvm.smax.i32(i32 %high.val.i, i32 0)
%cmp.i144 = icmp slt i32 %call144, -1
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks smax SPF. Should be fixed by llvm/llvm-project#82472.

dtcxzyw
dtcxzyw commented Feb 22, 2024
View reviewed changes
bench/libevent/optimized/evdns.c.ll
@@ -5406,8 +5406,9 @@ if.else.i177: ; preds = %if.then50
br i1 %tobool56.not, label %return, label %if.end58

if.end58: ; preds = %if.else.i177
%max.call.i = tail call i32 @llvm.smin.i32(i32 %conv.i.i, i32 255)
%retval.0.i178.ph = tail call i32 @llvm.smax.i32(i32 %max.call.i, i32 1)
%cmp1.i = icmp slt i32 %conv.i.i, 1
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by llvm/llvm-project#82472.

@dtcxzyw dtcxzyw closed this Feb 22, 2024
@dtcxzyw dtcxzyw deleted the test-pr82478 branch September 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtcxzyw