Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: PR112742 #1520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pre-commit: PR112742 #1520

wants to merge 2 commits into from

Conversation

dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Oct 19, 2024

Link: llvm/llvm-project#112742
Requested by: @dtcxzyw

@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

runner: buildkitsandbox
baseline runner: cseadmin-PowerEdge-R830
baseline: llvm/llvm-project@952dafb
patch: llvm/llvm-project#112742
sha256: 9edb4b3d1497d954ca81fe6efa02c7e540161e592fc3280df48a86ff7c92fdd9
commit: f40c8b3
9281 files changed, 1783938 insertions(+), 1779048 deletions(-)

Compilation time result (by files):
Top 5 improvements:
  g2o/vertex_ellipse.cpp.ll 8493367412 -> 7882476347 -7.19%
  gromacs/bwt.c.ll 194756585 -> 186018843 -4.49%
  wasmtime-rs/2ly4gzztxx8hlwxv.ll 14772807779 -> 14186631741 -3.97%
  icu/scriptset.ll 262446106 -> 252758744 -3.69%
  openssl/libcrypto-lib-aes_ige.ll 155386284 -> 150204128 -3.34%
Top 5 regressions:
  tokenizers-rs/4hn9gefsll13qr1r.ll 15829291077 -> 22367767191 +41.31%
  llvm/UnicodeCaseFold.cpp.ll 917742786 -> 1224851110 +33.46%
  hermes/hbc-attribute.cpp.ll 1500109099 -> 1856737058 +23.77%
  php/zend_virtual_cwd.ll 1036010486 -> 1220984133 +17.85%
  openjdk/vmIntrinsics.ll 906026608 -> 1062744424 +17.30%

Overall: 0.19709001%

Compilation time result (by projects):
Top 5 improvements:
  double_conversion 3658657814 -> 3635983390 -0.62%
  tinympc 18736574682 -> 18709331143 -0.15%
Top 5 regressions:
  tokenizers-rs 136764564165 -> 143381754222 +4.84%
  php 429109460455 -> 439829203503 +2.50%
  osqp 4308289440 -> 4357183553 +1.13%
  ncnn 540505265754 -> 546192408534 +1.05%
  duckdb 1006894653991 -> 1017470683353 +1.05%

Overall: 0.21203267%

Improvements:
correlated-value-propagation.NumMinMax 8636 -> 9335 +8.09%
licm.NumFPAssociationsHoisted 181 -> 185 +2.21%
loop-delete.NumBackedgesBroken 36160 -> 36468 +0.85%
instcombine.NumConstProp 99496 -> 99975 +0.48%
licm.NumBOAssociationsHoisted 5213 -> 5230 +0.33%
indvars.NumElimIdentity 1571 -> 1576 +0.32%
sccp.NumInstReplaced 142918 -> 143333 +0.29%
licm.NumMinMaxHoisted 1084 -> 1087 +0.28%
bdce.NumSExt2ZExt 4707 -> 4719 +0.25%
loop-load-elim.NumLoopLoadEliminted 790 -> 792 +0.25%
Regressions:
correlated-value-propagation.NumSMinMax 4935 -> 4031 -18.32%
correlated-value-propagation.NumSICmps 43203 -> 35704 -17.36%
correlated-value-propagation.NumSExt 35686 -> 34802 -2.48%
licm.NumAddSubHoisted 892 -> 870 -2.47%
gvn.NumGVNEqProp 309351 -> 303017 -2.05%
loop-simplifycfg.NumLoopExitsDeleted 2650 -> 2604 -1.74%
indvars.NumElimRem 188 -> 185 -1.60%
correlated-value-propagation.NumAShrsRemoved 266 -> 262 -1.50%
indvars.NumElimCmp 43579 -> 43005 -1.32%
loop-simplifycfg.NumTerminatorsFolded 8014 -> 7960 -0.67%

f40c8b3 pre-commit: Update
1 2 bench/abc/optimized/fxuReduce.c.ll
19 20 bench/abseil-cpp/optimized/float_conversion.cc.ll
3 4 bench/abseil-cpp/optimized/parser_test.cc.ll
37 42 bench/annoy/optimized/annoymodule.ll
6 8 bench/arrow/optimized/hashing.cc.ll
18 17 bench/arrow/optimized/reader.cc.ll
20 19 bench/arrow/optimized/sparse_tensor.cc.ll
24 25 bench/assimp/optimized/IFCGeometry.cpp.ll
6 11 bench/assimp/optimized/TriangulateProcess.cpp.ll
18 13 bench/bullet3/optimized/btDeformableMultiBodyConstraintSolver.ll
17 22 bench/bullet3/optimized/btPolyhedralConvexShape.ll
13 11 bench/bullet3/optimized/btSequentialImpulseConstraintSolver.ll
10 15 bench/casadi/optimized/cs_compress.c.ll
6 9 bench/casadi/optimized/getnonzeros.cpp.ll
14 17 bench/casadi/optimized/interpolant.cpp.ll
18 21 bench/casadi/optimized/split.cpp.ll
37 34 bench/ceres/optimized/dense_normal_cholesky_solver.cc.ll
12 16 bench/ceres/optimized/problem_impl.cc.ll
31 29 bench/clamav/optimized/pdf.c.ll
8 9 bench/cmake/optimized/archive_read_support_format_zip.c.ll
8 5 bench/cmake/optimized/archive_write_set_format_mtree.c.ll
12 14 bench/cmake/optimized/bzlib.c.ll
18 16 bench/cmake/optimized/nghttp2_session.c.ll
15 11 bench/cpython/optimized/_posixsubprocess.ll
4 3 bench/cpython/optimized/frameobject.ll
18 22 bench/cpython/optimized/itertoolsmodule.ll
7 8 bench/curl/optimized/libcurl_la-openssl.ll
7 4 bench/cvc5/optimized/inst_strategy_enumerative.cpp.ll
72 58 bench/double_conversion/optimized/fixed-dtoa.cc.ll
14 15 bench/eastl/optimized/BenchmarkMap.cpp.ll
13 14 bench/eastl/optimized/BenchmarkSet.cpp.ll
11 12 bench/eastl/optimized/BenchmarkVector.cpp.ll
6 5 bench/faiss/optimized/VectorTransform.cpp.ll
5 6 bench/faiss/optimized/lattice_Zn.cpp.ll
24 23 bench/faiss/optimized/pq4_fast_scan.cpp.ll
7 10 bench/flac/optimized/metadata_object.c.ll
3 7 bench/flac/optimized/stream_decoder.c.ll
2 6 bench/flac/optimized/stream_encoder_framing.c.ll
38 34 bench/freetype/optimized/truetype.c.ll
16 13 bench/git/optimized/column.ll
5 2 bench/git/optimized/diffcore-rename.ll
1 6 bench/git/optimized/run-command.ll
5 3 bench/git/optimized/shortlog.ll
19 24 bench/graphviz/optimized/bfs.c.ll
18 24 bench/grpc/optimized/systemd_utils.cc.ll
15 12 bench/harfbuzz/optimized/hb-static.cc.ll
4 6 bench/hdf5/optimized/sio_engine.c.ll
3 2 bench/hermes/optimized/ConsecutiveStringStorage.cpp.ll
26 30 bench/hermes/optimized/StringRef.cpp.ll
46 48 bench/html5ever-rs/optimized/38n20yzo26sy51uu.ll
43 42 bench/hwloc/optimized/topology-linux.ll
4 8 bench/hyperscan/optimized/asserts.cpp.ll
25 27 bench/hyperscan/optimized/rose_build_dedupe.cpp.ll
21 17 bench/hyperscan/optimized/rose_build_lookaround.cpp.ll
7 3 bench/icu/optimized/pkgdata.ll
36 32 bench/imgui/optimized/imgui_demo.cpp.ll
44 37 bench/imgui/optimized/imgui_widgets.cpp.ll
1 5 bench/ipopt/optimized/SensIndexSchurData.ll
10 9 bench/jq/optimized/builtin.ll
36 34 bench/libevent/optimized/http.c.ll
17 23 bench/libjpeg-turbo/optimized/jdmainct.c.ll
5 9 bench/libpng/optimized/pngset.c.ll
7 11 bench/libquic/optimized/a_print.c.ll
34 38 bench/libquic/optimized/base64.c.ll
3 1 bench/libuv/optimized/process.c.ll
4 12 bench/libuv/optimized/thread.c.ll
4 5 bench/libwebp/optimized/alpha_processing_sse2.c.ll
20 27 bench/lightgbm/optimized/gbdt.cpp.ll
20 28 bench/lightgbm/optimized/voting_parallel_tree_learner.cpp.ll
24 34 bench/linux/optimized/keyctl.ll
2 1 bench/llvm/optimized/CGLoopInfo.cpp.ll
5 1 bench/llvm/optimized/Instruction.cpp.ll
34 36 bench/lodepng/optimized/lodepng.cpp.ll
31 27 bench/luajit/optimized/minilua.ll
6 7 bench/luau/optimized/Conformance.test.cpp.ll
20 16 bench/meshlab/optimized/eigen_mesh_conversions.cpp.ll
70 61 bench/meshoptimizer/optimized/stripifier.cpp.ll
21 33 bench/mimalloc/optimized/bitmap.c.ll
2 3 bench/minetest/optimized/content_mapblock.cpp.ll
52 51 bench/mitsuba3/optimized/xml.cpp.ll
12 18 bench/mold/optimized/gdb-index.cc.ALPHA.cc.ll
9 13 bench/msdfgen/optimized/save-png.cpp.ll
2 4 bench/ncnn/optimized/convolution.cpp.ll
8 6 bench/nghttp2/optimized/nghttp2_session.c.ll
14 24 bench/oiio/optimized/nullimageio.cpp.ll
41 38 bench/openexr/optimized/ImfRgbaFile.cpp.ll
2 5 bench/openjdk/optimized/p11_sign.ll
6 3 bench/openmpi/optimized/nbc_ialltoallv.ll
26 16 bench/openvdb/optimized/LevelSetMeasure.cc.ll
52 41 bench/pbrt-v4/optimized/aggregates.cpp.ll
55 54 bench/proj/optimized/isea.cpp.ll
22 30 bench/pugixml/optimized/pugixml.cpp.ll
5 4 bench/qemu/optimized/hw_usb_hcd-ohci.c.ll
35 24 bench/quantlib/optimized/bivariatestudenttdistribution.ll
30 40 bench/quantlib/optimized/cmsmarketcalibration.ll
36 37 bench/quest/optimized/QuEST_validation.c.ll
7 12 bench/recastnavigation/optimized/OffMeshConnectionTool.cpp.ll
16 20 bench/redis/optimized/t_stream.ll
4 2 bench/redis/optimized/zipmap.ll
12 22 bench/rocksdb/optimized/db_filesnapshot.cc.ll
32 35 bench/rocksdb/optimized/locktree.cc.ll
15 16 bench/ruby/optimized/compile.ll
49 45 bench/ruby/optimized/numeric.ll
14 12 bench/sentencepiece/optimized/stringprintf.cc.ll
34 31 bench/sentencepiece/optimized/unigram_model.cc.ll
7 9 bench/slurm/optimized/node_scheduler.ll
37 31 bench/slurm/optimized/proc_args.ll
38 39 bench/softposit-rs/optimized/1jooigl29qhneyer.ll
46 47 bench/softposit-rs/optimized/m1vpptg00bzmp9y.ll
26 24 bench/spike/optimized/interactive.ll
59 72 bench/stat-rs/optimized/4iyrhmyzjfh29528.ll
31 32 bench/stb/optimized/stb_connected_components.c.ll
44 42 bench/stb/optimized/stb_tilemap_editor.c.ll
43 48 bench/sundials/optimized/arkode_root.c.ll
41 46 bench/sundials/optimized/cvode.c.ll
25 28 bench/typst-rs/optimized/d6l9ieo9tcw33dn.ll
3 6 bench/verilator/optimized/V3Tristate.cpp.ll
14 18 bench/wasmedge/optimized/alias.cpp.ll
11 15 bench/wasmedge/optimized/codegen.cpp.ll
17 18 bench/wireshark/optimized/strutil.c.ll
22 25 bench/wolfssl/optimized/asn.c.ll
17 16 bench/wolfssl/optimized/internal.c.ll
24 27 bench/yosys/optimized/anlogic_eqn.ll
32 30 bench/zfp/optimized/encode4d.c.ll
26 25 bench/zstd/optimized/huf_decompress.c.ll
4 1 bench/zxing/optimized/DMDetector.cpp.ll
1 3 bench/zxing/optimized/PDFCodewordDecoder.cpp.ll
13 12 bench/zxing/optimized/PDFWriter.cpp.ll

goldsteinn
goldsteinn reviewed Oct 19, 2024
View reviewed changes
bench/arrow/optimized/hashing.cc.ll
@@ -188,13 +187,12 @@ do.body.i: ; preds = %do.body.preheader.i
br i1 %cmp.i23.i, label %if.then.i.i, label %if.else.i24.i

if.then.i.i: ; preds = %do.body.i
%conv.i29.i = sext i32 %reader.sroa.13.0.i to i64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would expect nneg here no?

dtcxzyw
dtcxzyw commented Oct 19, 2024
View reviewed changes
bench/cmake/optimized/nghttp2_session.c.ll
br i1 %17, label %24, label %18
%17 = icmp slt i64 %14, 0
%18 = icmp samesign ugt i64 %14, %spec.select
%or.cond = select i1 %17, i1 true, i1 %18
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fold

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the poison generating flag?
https://godbolt.org/z/Wj49jnW5T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldsteinn goldsteinn goldsteinn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtcxzyw @goldsteinn