Skip to content

FitFile.get_messages remove parsing names to int, remove Python 2 str shim #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2018
Merged

FitFile.get_messages remove parsing names to int, remove Python 2 str shim #66

merged 1 commit into from
Apr 25, 2018

Conversation

@xmedeko
Copy link
Contributor

@xmedeko xmedeko commented Apr 25, 2018

Fix #64

I've also made changes:

@xmedeko
FitFile.get_messages remove parsing names to int, remove Python 2 str…
460aff7 
… shim

Use utils.is_iterable and use set for quicker in test
@xmedeko xmedeko mentioned this pull request Apr 25, 2018
Closed
@pR0Ps pR0Ps self-requested a review April 25, 2018 12:38
@xmedeko xmedeko merged commit 3fa1fc0 into dtcooper:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pR0Ps pR0Ps pR0Ps approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xmedeko @pR0Ps