Skip to content

Conversation

@xmedeko
Copy link
Contributor

@xmedeko xmedeko commented Mar 23, 2018

Fix #59

@xmedeko
Copy link
Contributor Author

xmedeko commented Mar 29, 2018

@dtcooper @pR0Ps Do you agree to break backward compatibility a bit with this PR?

@pR0Ps
Copy link
Collaborator

pR0Ps commented Apr 5, 2018

I'm ok with breaking backwards compatibility, but only in the cases where the version is bumped to reflect it (ie semvar).

In this case, I don't think it's worth it by itself. It's not doing anything new or different, it's just removing a feature. If there are other breaking changes happening then this can go in with them, but IMO it's not worth breaking backwards compatibility just for this.

@xmedeko
Copy link
Contributor Author

xmedeko commented Apr 6, 2018

@prop This saves a lot of memory. So is necessary when running fitparse on a server.

I think more BC changes should be made to fitparse in regards of speed. So, a version bump is necessary. Better to discuss it somewhere else.

@dtcooper
Copy link
Owner

What about an argument when instantiating FitFile's __init__ method to turn on/off the message cache?

@xmedeko
Copy link
Contributor Author

xmedeko commented Jun 12, 2018

@dtcooper Yes, an extra parameter would do the job, too. But IMO the FitFile has too many responsibilities and should be broken to more classes. See #72 for my proposal.

@pR0Ps
Copy link
Collaborator

pR0Ps commented Dec 30, 2020

Implemented in 08d49be

@pR0Ps pR0Ps closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not cache messages in FitParse._messages

3 participants