[ENH] Update penalties.py to fix issue #368 Positive Constraint #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update penalties.py to fix issue dswah#368 by adding the functionality to constrain splines as positive only.
Owner
|
Closing and re-opening the PR to trigger the CI workflows again. |
Owner
|
@FloeFoxon Thanks for this clean and complete contribution! I believe that enforcing positivity in the coefficients will just force the negative part to be absorbed into the model intercept... |
dswah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update penalties.py to fix issue #368 by adding the functionality to constrain splines as positive only, as described in my comment on issue #368.