Update gitignore logic to catch more cases #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
reviewed
May 26, 2025
r4victor
reviewed
May 26, 2025
jvstme
reviewed
May 27, 2025
Co-authored-by: Victor Skvortsov <vds003@gmail.com>
colinjc
force-pushed
the
cc/update-gitignore-to-catch-more-cases
branch
from
5d78c2b to
108bd86
Compare
jvstme
approved these changes
May 28, 2025
There was a problem hiding this comment.
@colinjc, thanks for the PR. Replacing our gitignore implementation with a more mature one is a good idea.
The latest commit was building malformed unpackable archives, but I fixed it with a couple of edits. Will merge now, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation was missing support for a ** which was pretty critical. This updates the logic to use an existing library which already supports **.