Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are many installations with only default 2.6 Python in place an no "supported" updates are available in official repos for OS we should try to stay Python 2.6 compatible... (At least all the Redhat/Centos 6 systems are affected.)
Up to now there is "nothing" in PyInotify that is not working with 2.6 and it would be fine if that could last for a while, at least as long enterprise operating systems like Centos/Redhat 6 are supported and offer no official update to Python 2.7.
I know there are Python 3.4 packages available for these two via epel, but unfortunately in some companies are still policies in place that enforce pyhton 2.6 for commonly used scripts...
And there are companies still having unsupported Centos/Redhat 5 systems in production where the latest version available via epel is 2.6.
include v2.6 and for that version do the following addtional tasks:
import unittest2 as unittest for python version 2.6
change debug code to format syntax understood by 2.6
Drawback of this: the travis test for 2.6 takes quite much time because some dependencies need to be compiled. But I think this is not a big issue.