Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing errno for library calls #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Elias481
Copy link

Fix to enable inotify errno + message in Exceptions resulting from unsuccessfull library calls.

@coveralls
Copy link

coveralls commented Sep 19, 2018

Coverage Status

Coverage decreased (-2.8%) to 82.258% when pulling 3fc5231 on Elias481:fix-missing-errno-for-library-calls into 288a2b0 on dsoprea:master.

…t happier

 (it still does not like all the dead code..)
@Elias481
Copy link
Author

Coverage Status

Coverage decreased (-2.8%) to 82.258% when pulling 3fc5231 on Elias481:fix-missing-errno-for-library-calls into 288a2b0 on dsoprea:master.

The coverall report is not really good working...
The overall coverage did increase and not decrease with my additional commit 3fc5231... (~ 86,3 overall not 82,258%..)
It compares the percentage of only few files to the previous percentage of all files or whichever combination of file had been selected on that run?

@dsoprea
Copy link
Owner

dsoprea commented Aug 25, 2020

Let's squash these commits together, and revisit how we're getting the errno integer and string into the exception messages. Detailed in comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants