[TextInput] Fixes 'AutoCorrect on Submit' bug

Catches a spelling auto correction when the 'Return' key is pressed and makes sure that a `RCTTextEventTypeChange` event fires. - Doesn't increment the `nativeEventCount` as it doesn't need to match up with JS. - Extracts a few methods in `RCTTextFieldManager` to reduce duplication introduced. Resolves: facebook#2552
dsibiski · Jan 11, 2016 · 58def5a · 58def5a
1 parent e08a7f3
commit 58def5a
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 6 deletions.
diff --git a/Libraries/Text/RCTTextField.h b/Libraries/Text/RCTTextField.h
@@ -32,5 +32,6 @@
 - (void)textFieldDidChange;
 - (void)sendKeyValueForString:(NSString *)string;
 - (BOOL)textFieldShouldEndEditing:(RCTTextField *)textField;
+- (void)sendChangeEvent;
 
 @end
diff --git a/Libraries/Text/RCTTextField.m b/Libraries/Text/RCTTextField.m
@@ -168,6 +168,11 @@ - (BOOL)autoCorrect
 - (void)textFieldDidChange
 {
   _nativeEventCount++;
+  [self sendChangeEvent];
+}
+
+- (void)sendChangeEvent
+{
   [_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange
                                  reactTag:self.reactTag
                                      text:self.text

diff --git a/Libraries/Text/RCTTextFieldManager.m b/Libraries/Text/RCTTextFieldManager.m
@@ -38,20 +38,28 @@ - (BOOL)textField:(RCTTextField *)textField shouldChangeCharactersInRange:(NSRan
   }
 
   if (textField.maxLength == nil || [string isEqualToString:@"\n"]) {  // Make sure forms can be submitted via return
+    if (textField.autocorrectionType == UITextAutocorrectionTypeYes) { // If autoCorrect is on...
+      if (range.length > 0 && ![string isEqualToString:@""]) { // This catches an auto correction on submit.
+        textField.text = [self replaceText:textField.text.mutableCopy inRange:range withString:string];
+        // Collapse selection at end of insert to match normal paste behavior
+        textField.selectedTextRange = [self textRangeForTextField:textField
+                                           withTextPositionOffset:(range.location + string.length)];
+        [textField sendChangeEvent];
+        return NO;
+      }
+    }
     return YES;
   }
+
   NSUInteger allowedLength = textField.maxLength.integerValue - textField.text.length + range.length;
   if (string.length > allowedLength) {
     if (string.length > 1) {
       // Truncate the input string so the result is exactly maxLength
       NSString *limitedString = [string substringToIndex:allowedLength];
-      NSMutableString *newString = textField.text.mutableCopy;
-      [newString replaceCharactersInRange:range withString:limitedString];
-      textField.text = newString;
+      textField.text = [self replaceText:textField.text.mutableCopy inRange:range withString:limitedString];
       // Collapse selection at end of insert to match normal paste behavior
-      UITextPosition *insertEnd = [textField positionFromPosition:textField.beginningOfDocument
-                                                          offset:(range.location + allowedLength)];
-      textField.selectedTextRange = [textField textRangeFromPosition:insertEnd toPosition:insertEnd];
+      textField.selectedTextRange = [self textRangeForTextField:textField
+                                         withTextPositionOffset:(range.location + allowedLength)];
       [textField textFieldDidChange];
     }
     return NO;
@@ -73,6 +81,23 @@ - (BOOL)textFieldShouldEndEditing:(RCTTextField *)textField
   return [textField textFieldShouldEndEditing:textField];
 }
 
+- (NSString *)replaceText:(NSMutableString *)originalString
+                  inRange:(NSRange)range
+               withString:(NSString *)string
+{
+  NSMutableString *newString = originalString;
+  [newString replaceCharactersInRange:range withString:string];
+  return newString;
+}
+
+- (UITextRange *)textRangeForTextField:(UITextField *)textField
+                withTextPositionOffset:(NSUInteger)offset
+{
+      UITextPosition *insertEnd = [textField positionFromPosition:textField.beginningOfDocument
+                                                          offset:offset];
+      return [textField textRangeFromPosition:insertEnd toPosition:insertEnd];
+}
+
 RCT_EXPORT_VIEW_PROPERTY(caretHidden, BOOL)
 RCT_EXPORT_VIEW_PROPERTY(autoCorrect, BOOL)
 RCT_REMAP_VIEW_PROPERTY(editable, enabled, BOOL)