Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to share ASTs between projects #660

Open
dsherret opened this issue Jul 8, 2019 · 1 comment
Open

Ability to share ASTs between projects #660

dsherret opened this issue Jul 8, 2019 · 1 comment
Labels
enhancement performance

Comments

@dsherret
Copy link
Owner

dsherret commented Jul 8, 2019

See #658.

It might be useful to have a document registry that could be shared between projects.
@dsherret dsherret mentioned this issue Jul 8, 2019
Open
dsherret added a commit that referenced this issue Nov 23, 2019
@dsherret
chore: #660 - Internal start for document caches. This code isn't bei…
73672d2 
…ng used right now, but may be used in the future.

Squashed commit of the following:

commit 4acf117
Author: David Sherret <dsherret@gmail.com>
Date:   Sat Nov 23 13:06:26 2019 -0500

    Remove use of document cache because it wasn't faster. Will look into this more later.

commit d5f82fb
Author: David Sherret <dsherret@gmail.com>
Date:   Sat Nov 23 12:56:39 2019 -0500

    Various changes.

commit 788e73f
Author: David Sherret <dsherret@gmail.com>
Date:   Fri Nov 22 22:49:34 2019 -0500

    So sad. This cloning is slower than re-parsing the file.

    I'll probably look into creating a proxy of all the objects instead.

commit 358f96d
Author: David Sherret <dsherret@gmail.com>
Date:   Sun Nov 17 17:52:09 2019 -0500

    Beginnings of a document cache where source file objects can be shared across projects.
@dsherret
Copy link
Owner Author

I decided to merge some of this to master, but I ended up reverting the implementation because it wasn't faster than just reparsing the source files each time:

4acf117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsherret