Fix SizePreferenceKey reduce logic #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the reduce method to sum the width and height of CGSize values instead of leaving the value unchanged. I also updated defaultValue to be a constant. This resolves a UI overlapping issue in CarouselStack.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the SizePreferenceKey reduce logic to properly accumulate CGSize values instead of ignoring them. The fix addresses a UI overlapping issue in CarouselStack when using complex element views with non-default initial indices.
- Implements proper size accumulation by summing width and height values in the reduce method
- Changes defaultValue from var to let for immutability
- Replaces empty reduce method with meaningful size aggregation logic
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the reduce method to sum the width and height of CGSize values instead of leaving the value unchanged. This resolves a UI overlapping issue in
CarouselStackwhen the element view is complex and the initial index is not the default.