Fix bug in media upload, add optional detectoin of mime-/file-type #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your work! ❤️ |
Comment on lines
+38
to
+40
| /// A handle to access libmagic for mime-types. | ||
| #[cfg(feature = "magic")] | ||
| magic: magic::Cookie, |
There was a problem hiding this comment.
This was a semver-incompatible change as reported in #12 because the feature is a default feature.
Please roll back the change or make the feature optional!
There was a problem hiding this comment.
Apparently, I'm unaware of the implications of features on semver, what sort of release is required for a new default feature which is not exposed as an API to the user? I was under the impression SemVer was as simple as
- Major: breaking changes
- Minor: new features (in the sense of an additional function or set of functions which are exposed)
- Patch: Bug-fixes and changes which don't affect the API
There was a problem hiding this comment.
Yeah, you're right about the semver rules. But this change introduced an API change and was released as a patchlevel release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was found where the client didn't include any file-type information with media uploads. This change fixes that by making two changes:
"magic"feature, the file will be inspected to determine what kind of file it is, and the mime-type is included in the form. This may help with debugging and providing more robust error messages in the case where a file's extension is misinterpreted or different from the actual filetype, and could help the server better understand what to do with this file. To turn off this feature, disable the"magic"default feature.This will resolve #6 . Thanks to @ckruse for reporting this bug.