-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client method to wait for attachment processing #62
Conversation
@dscottboggs I'll check it tonight. Thanks. |
I think the new method pub async fn wait_for_processing(
&self,
mut attachment: Attachment,
polling_interval: Duration,
timeout: Duration,
) -> Result<ProcessedAttachment> |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you! :)
Although a more appropriate way to implement the timeout is to use the tokio::select!
, so that it will return immediately if it times out, instead of remaining asleep. But in this case, the value of polling_time
user input is most likely very short, so this is not a big problem.
Well, now that you say that, I don't think I'm going to keep this feature.
|
651388b
to
dad04e7
Compare
This should resolve #61. @SpriteOvO, can you confirm this suits your use-case?