Skip to content

Conversation

@digiguru
Copy link

Hi @dschaffe

I'm sorry for taking this on my own back, but I've done a first sweep of integrating Blanket.js (a code coverage tool for unit tests) into the awsome extension you've made.

The change is very straightforward,

Firstly to add code coverage in one of the included files you simply append "*" to the end of that file, for example:

/* brackets-xunit: includes=jquery.js,mySource.js*,underscore.js,raphael.2.0.1.js */

... this means you don't have to see how many lines of jQuery, underscore or raphael you failed to cover - very useful!

I've added the necessary unit test to parseIncludes.

Blacket.js works for qunit out of the box, and I believe it's possible to add adapters for the other test runners.

Can you let me know if you are likely to include this in the extension, if so I'll carry on with the other adapters!

@dschaffe
Copy link
Owner

Thanks for investigating. Looks really cool. I also encountered the caching issue. The best workaround I came up with is to write temporary files to a numbered directory you can increment with each modification. Maybe posting to the brackets forum someone may have a better solution.

@dschaffe
Copy link
Owner

I was able to run code coverage on a qunit test. The functionality looks great. I would merge the pull request. I am not sure if you are better off publicizing your own fork. I have not had much time to work on brackets lately and I thinkam not going to be working on javascript related projects for a while. I would definitely recommend posting your work on the brackets google group, https://groups.google.com/forum/#!forum/brackets-dev. Lots of people on the core brackets team and others are interested in code coverage support. But as I don't have much time now I would encourage you to use any of my code however you wish. Thanks.

@digiguru
Copy link
Author

I'm happy to setup a "xunit" account if you want so that can become the master and if you ever feel like dipping in in the future, jump in and say hi!

@dschaffe
Copy link
Owner

Sure that's a great idea.

Dan

On Thu, Jul 11, 2013 at 11:26 AM, digiguru notifications@github.com wrote:

I'm happy to setup a "xunit" account if you want so that can become the
master and if you ever feel like dipping in in the future, jump in and say
hi!


Reply to this email directly or view it on GitHubhttps://github.com//pull/32#issuecomment-20819578
.

@digiguru
Copy link
Author

Added Jasmine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants