-
Notifications
You must be signed in to change notification settings - Fork 133
xService: Fix Get-TargetResource always returning all user type as builtInAccount #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello @johlju , |
|
We should not return those proposed values from Get-function. Suggest to make a helper function that can return the type of credential that can be used in Get-, Test-, and Set-function as needed. For example |
I will adapt accordingly. Thanks for the review |
Pull Request (PR) description
Current xService resource always return user running the service as builtInAccount
Evaluating of type was not done to avoid call to AD to determine if user running the service is a gMSA
Evaluation is now done based on format as gMSA is always structured in the same format contoso\mygmsauser$
This Pull Request (PR) fixes the following issues
Fixes #759
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is