Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GitVersion task to fix pipeline - Fixes #746 #747

Merged
merged 2 commits into from
Apr 10, 2022

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 10, 2022

Pull Request (PR) description

This PR replaces the GitVersion task in the pipeline to fix it.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing when you have time?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #747 (4f6fc7e) into main (475885c) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #747   +/-   ##
===================================
- Coverage    72%    72%   -1%     
===================================
  Files        30     30           
  Lines      4427   4427           
===================================
- Hits       3213   3199   -14     
- Misses     1214   1228   +14     
Impacted Files Coverage Δ
...sources/DSC_xDSCWebService/DSC_xDSCWebService.psm1 88% <ø> (ø)
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 70% <ø> (ø)
...sionConfiguration/DSC_xPSSessionConfiguration.psm1 0% <ø> (ø)
...ces/DSC_xPackageResource/DSC_xPackageResource.psm1 76% <ø> (-4%) ⬇️
...urces/DSC_xScriptResource/DSC_xScriptResource.psm1 100% <ø> (ø)
...ces/DSC_xServiceResource/DSC_xServiceResource.psm1 93% <ø> (ø)
...Resources/DSC_xUserResource/DSC_xUserResource.psm1 53% <ø> (ø)
...urces/DSC_xWindowsFeature/DSC_xWindowsFeature.psm1 86% <ø> (ø)
.../xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1 0% <ø> (ø)
...xEnvironmentResource/DSC_xEnvironmentResource.psm1 91% <100%> (ø)
... and 1 more

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit e2582d3 into dsccommunity:main Apr 10, 2022
@johlju johlju removed the needs review The pull request needs a code review. label Apr 10, 2022
@PlagueHO PlagueHO deleted the Issue-746 branch April 10, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitVersion task in Pipeline
2 participants