Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .VSCode Settings for PSScriptAnalyzer Rules - Fixes #32 #33

Merged
merged 1 commit into from
Sep 30, 2018

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Sep 29, 2018

Pull Request (PR) description

Added .VSCode settings for applying DSC PSSA rules

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - just a very minor one - would you review when you get a moment.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Sep 29, 2018
@codecov
Copy link

codecov bot commented Sep 29, 2018

Codecov Report

Merging #33 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #33   +/-   ##
=================================
  Coverage   84%   84%           
=================================
  Files        3     3           
  Lines      287   287           
=================================
  Hits       242   242           
  Misses      45    45

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit b415aee into dev Sep 30, 2018
@PlagueHO PlagueHO deleted the Issue-32 branch September 30, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .VSCode Settings for PSScriptAnalyzer Rules
2 participants