Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct name of examples in configuration - Fixes #24 #25

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Aug 6, 2018

Pull Request (PR) description
This PR corrects the configuration names in the Example files to match the filename of the configuration, sans the numeric prefix.

This Pull Request (PR) fixes the following issues:

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@johlju - would you mind taking a look at this one when you can?


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #25 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #25   +/-   ##
=================================
  Coverage   89%   89%           
=================================
  Files        2     2           
  Lines      258   258           
=================================
  Hits       230   230           
  Misses      28    28

@johlju johlju added the needs review The pull request needs a code review. label Aug 6, 2018
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Aug 6, 2018
@PlagueHO PlagueHO merged commit d4fd878 into dev Aug 7, 2018
@PlagueHO PlagueHO deleted the Issue-24 branch August 7, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct Configuration Names in Examples
2 participants