Skip to content

SqlSetup: Update requirements section#1591

Merged
johlju merged 1 commit intodsccommunity:masterfrom
johlju:fix/sqlsetup-documentation
Jul 13, 2020
Merged

SqlSetup: Update requirements section#1591
johlju merged 1 commit intodsccommunity:masterfrom
johlju:fix/sqlsetup-documentation

Conversation

@johlju
Copy link
Member

@johlju johlju commented Jul 10, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #1591 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1591   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        6082    6082           
======================================
  Hits         5978    5978           
  Misses        104     104           
Flag Coverage Δ
#unit 98% <ø> (ø)

@johlju johlju force-pushed the fix/sqlsetup-documentation branch from f78153d to d2241d9 Compare July 13, 2020 11:32
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit a75b66c into dsccommunity:master Jul 13, 2020
@johlju johlju deleted the fix/sqlsetup-documentation branch July 13, 2020 15:28
@johlju johlju removed the needs review The pull request needs a code review. label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SqlServerDsc SqlSetup "Access Denied" on install Domain Admin needed.

1 participant