-
Notifications
You must be signed in to change notification settings - Fork 90
Added repository to enable/disable network adapter power management. #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update to use DSCResource.test Shared Code - Fixes #177
|
@edycus, It will cover your contributions to all Microsoft-managed open source projects. |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage ? 93%
=======================================
Files ? 16
Lines ? 1149
Branches ? 0
=======================================
Hits ? 1069
Misses ? 80
Partials ? 0Continue to review full report at Codecov.
|
|
I finally go a PR submitted. It seems to have failed some checks. Should I fix them and resubmit? |
|
@edycus, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Hi @edycus - it looks like you've submitted this PR to the master branch rather than the dev branch. All PRs need to go to the dev branch. Can you recreate the PR against the dev branch? |
|
Hi @edycus , is this one still active? It looks like the PR needs to be recreated against the dev branch. Happy to help out on getting this one through as I think this would be a great addition! |
|
Hi @edycus - is there anything you are waiting on for me? Do you think you'll get a chance to rebase this change against the dev branch? If not I can mark this as abandoned and someone may try to pick it up later on? |
|
No, I dropped the ball. Let me work in it.
Eric Dycus
…________________________________
From: Daniel Scott-Raynsford <notifications@github.com>
Sent: Friday, June 16, 2017 1:42:56 PM
To: PowerShell/xNetworking
Cc: edycus; Mention
Subject: Re: [PowerShell/xNetworking] Added repository to enable/disable network adapter power management. (#195)
Hi @edycus<https://github.com/edycus> - is there anything you are waiting on for me? Do you think you'll get a chance to rebase this change against the dev branch? If not I can mark this as abandoned and someone may try to pick it up later on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#195 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOO2On5NNqOOnVQdv13M5jtuHuc2qvrOks5sEujQgaJpZM4MYq_i>.
|
|
No problem @edycus - glad to have your help! 😁 |
|
I submitted the pull. It's gave me a bunch of stuff I don't know what to do with. Lol. I'm a little lost on how this works.
Eric Dycus
…________________________________
From: Daniel Scott-Raynsford <notifications@github.com>
Sent: Friday, June 16, 2017 3:32:21 PM
To: PowerShell/xNetworking
Cc: edycus; Mention
Subject: Re: [PowerShell/xNetworking] Added repository to enable/disable network adapter power management. (#195)
No problem @edycus<https://github.com/edycus> - glad to have your help! 😁
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#195 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOO2OpiI2ZJm5fJVfaSyGpnFc9ovvmkeks5sEwJ1gaJpZM4MYq_i>.
|
|
I'll close this one because it has been replaced by #219 |
Added repository to enable/disable network adapter power management.
This change is