Skip to content

Conversation

@edycus
Copy link

@edycus edycus commented Mar 9, 2017

Added repository to enable/disable network adapter power management.


This change is Reviewable

@msftclas
Copy link

msftclas commented Mar 9, 2017

@edycus,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@e3a5d53). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #195   +/-   ##
=======================================
  Coverage          ?    93%           
=======================================
  Files             ?     16           
  Lines             ?   1149           
  Branches          ?      0           
=======================================
  Hits              ?   1069           
  Misses            ?     80           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a5d53...ed0abff. Read the comment docs.

@edycus
Copy link
Author

edycus commented Mar 9, 2017

I finally go a PR submitted. It seems to have failed some checks. Should I fix them and resubmit?

@msftclas
Copy link

@edycus, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@PlagueHO
Copy link
Member

Hi @edycus - it looks like you've submitted this PR to the master branch rather than the dev branch. All PRs need to go to the dev branch. Can you recreate the PR against the dev branch?

@PlagueHO PlagueHO added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Mar 24, 2017
@PlagueHO
Copy link
Member

PlagueHO commented Jun 3, 2017

Hi @edycus , is this one still active? It looks like the PR needs to be recreated against the dev branch. Happy to help out on getting this one through as I think this would be a great addition!

@PlagueHO
Copy link
Member

Hi @edycus - is there anything you are waiting on for me? Do you think you'll get a chance to rebase this change against the dev branch? If not I can mark this as abandoned and someone may try to pick it up later on?

@edycus
Copy link
Author

edycus commented Jun 16, 2017 via email

@PlagueHO
Copy link
Member

No problem @edycus - glad to have your help! 😁

@edycus
Copy link
Author

edycus commented Jun 16, 2017 via email

@PlagueHO
Copy link
Member

I'll close this one because it has been replaced by #219

@PlagueHO PlagueHO closed this Jun 16, 2017
@joeyaiello joeyaiello removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants