Authentication with Swagger #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 2, 2020 10:12
-Added Swagger, to allow better visualisation of API(added in requirements.txt file). -Added Authentication app, which allows users to register. -Added Email Verification, which sends users verification tokens, which can then be successfully verified on the API (Email used is a test Gmail account. Details are in the setting.py file in ‘webapp’. - Added all Serializations and Models required to, register verify and login Users -Added Jwt for token generation (added in requirements.txt file) -Two tokens are generated, refresh and access - Added login through Swagger interface, which requires users to input generated token, to access information from the API. -Added Renderers in order to ensure consistent responses in the API, especially when an error is generated.
-Added Swagger, to allow better visualisation of API(added in requirements.txt file). -Added Authentication app, which allows users to register. -Added Email Verification, which sends users verification tokens, which can then be successfully verified on the API (Email used is a test Gmail account. Details are in the setting.py file in ‘webapp’. - Added Password and Token Reset by Email -Added Token Authentication check -Edited Read Me with Basic User Login and Registration Instructions
jbinvnt
requested changes
Aug 6, 2020
jbinvnt
requested changes
Aug 6, 2020
| def test_user_can_register_correctly(self): | ||
| res = self.client.post( | ||
| self.register_url, self.user_data, format="json") | ||
| #self.assertEqual(res.data['email'] ,self.user_data['email']) |
There was a problem hiding this comment.
Were these temporarily commented out because they were failing? If so, I would suggest fixing the issue causing them to fail and uncommenting.
There was a problem hiding this comment.
Yes, I was having an import Issue. Sorting it out now
Comment on lines
+40
to
+47
| email = serializers.EmailField( | ||
| max_length=255, min_length=8) | ||
| password = serializers.CharField( | ||
| max_length=68, min_length=3, write_only=True) | ||
| username = serializers.CharField( | ||
| max_length=255, min_length=3, read_only=True) | ||
| tokens = serializers.CharField( | ||
| max_length=68, min_length=3,read_only=True) |
There was a problem hiding this comment.
Is there a need for these specific min and max length values? If so, the source should be documented. Otherwise, in my experience all min/max length constraints should be set in the model and not in the serializer. Also, I believe that the email, password, and username fields all will be inherited automatically from the User model, so we should not need to add them manually here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Changes
-Added Swagger, to allow better visualisation of API(added in requirements.txt file).
-Added Authentication app, which allows users to register.
-Added Email Verification, which sends users verification tokens, which can then be successfully verified on the API (Email used is a test Gmail account. Details are in the setting.py file in ‘web app’.
-Added Token Authentication check
-Edited Read Me with Basic User Login and Registration Instructions
Have a look, and run the API. Then if you decide I should separate them. Then I will work on separating them.