Use uvx #97
Closed
Use uvx #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll reference the remote server in GitHub and configure clients to use `uvx`
- Replaced local server execution with uvx package-based configuration for improved reliability - Added GetUvxCommand helper to generate correct package version command string - Updated config generation to use `uvx mcp-for-unity` instead of local Python server - Modified Codex and client configuration validation to support uvx-based setup - Removed unused server source directory handling and related preferences - Updated tests to verify uvx command generation
We don't commit temp folders, tests are expected to clean up after themselves
…comparisons are not precise
- Replaced local server path detection with uvx-based package installation from git repository - Updated all configuration generators to use structured uvx command parts (command, --from URL, package) - Renamed UV path references to UVX for clarity and consistency - Added GetUvxCommandParts() helper to centralize uvx command generation - Added GetMcpServerGitUrl() to handle git repository URL construction - Updated client configuration validation
- Added GetUvxPackageSourcePath method to locate unity-mcp package in uv cache by traversing git checkouts - Replaced hardcoded "Dummy" path in PythonToolSyncProcessor with dynamic path resolution - Added validation for Server directory structure and pyproject.toml to ensure correct package location
Key thing is that MCPForUnity/UnityMcpServer/src is still deleted
…ystem - Removed PythonToolsAsset and file-based sync processor in favor of attribute-based tool discovery - Implemented CustomToolRegistrationProcessor with automatic registration on startup and script reload - Added registration enable/disable preference and force re-registration capability
- Implemented HTTP transport option with configurable URL/port alongside existing stdio mode - Added cache management service with menu item to clear uvx package cache - Updated config builder to generate transport-specific arguments and VSCode type field based on selected mode
- Replaced separate host/port arguments with single --http-url parameter for cleaner configuration - Updated server to parse URL and allow individual host/port overrides when needed - Consolidated HTTP client implementation with connection testing and tool execution support
…rt flag - Replaced --enable-http-server flag with --transport choice parameter (stdio/http) for clearer intent - Removed redundant HTTP port field from UI since HTTP mode uses the same URL/port as MCP client - Simplified server startup logic by consolidating transport mode determination
- Changed HTTP mode to use URL-based configuration instead of command-line arguments - Added proper cleanup of incompatible fields when switching between stdio and HTTP transports - Moved uvx command parsing inside stdio-specific block to avoid unnecessary processing in HTTP mode
- Implemented server management service with menu item to start local HTTP server in new terminal window - Added Git URL override setting in advanced configuration to allow custom server source for uvx --from - Integrated server management into service locator with validation for local-only server startup
- Removed auto-prefixing logic that added "http://" to URLs without protocol - Added placeholder text to guide users on expected URL format - Created dedicated url-field style class for better URL input styling
- Added initialize, ping, and disconnect methods to HttpMcpClient for proper MCP protocol session management - Implemented session ID tracking and header management for stateful HTTP connections - Added cross-platform terminal launcher support for Windows and Linux (previously macOS-only)
- Added proper JSON-RPC 2.0 request/response handling with request ID tracking - Included MCP protocol headers (version, session ID) for standard compliance - Added error handling for JSON-RPC error responses
- Added white-space: normal and flex-shrink properties to section headers and override labels to prevent text overflow - Created new help-text style class for consistent formatting of help text elements
- Added flex-wrap to setting rows to prevent overflow on narrow windows - Set flex-shrink: 0 on labels to maintain consistent width - Replaced max-width and margin-left with flex-basis for better flex behavior
- Capture Unity API calls on main thread before async operations to prevent threading issues - Update RegisterAllTools to use Task.Run pattern instead of GetAwaiter().GetResult() to avoid potential deadlocks - Add optional projectId parameter to RegisterAllToolsAsync for pre-captured values
…registration - Removed synchronous registration method and unused MCP bridge logic from CustomToolRegistrationService - Changed tool registration to use direct HTTP POST to /register-tools endpoint instead of MCP protocol - Added FastAPI HTTP routes alongside existing MCP tools for more flexible tool management access
- Created HttpEndpointUtility to normalize and manage base URLs consistently - Replaced scattered EditorPrefs calls with utility methods that handle URL normalization - Ensured base URL storage excludes trailing paths like "/mcp" for cleaner configuration
Clean up import organization by moving imports to the top of the file, removing duplicate imports scattered throughout the code, and sorting imports alphabetically within their groups (standard library, third-party, local). Remove unnecessary import aliases and consolidate duplicate urlparse and time imports.
…ing Unity focus - Add immediate restart attempt in OnAfterAssemblyReload() when Unity is not compiling - Enhanced compile detection to check both EditorApplication.isCompiling and CompilationPipeline.isCompiling - Add brief port release wait in StdioBridgeHost before switching ports to reduce port thrash - Fallback to delayCall/update loop only when Unity is actively compiling This fixes the issue where domain reloads (e.g., script edits) would cause connection loss until Unity window was refocused, as EditorApplication.update only fires when Unity has focus.
We use HTTP mode by default in docker, this is what will be hosted remotely if one chooses to. We needed to update the uvicorn package to a version with websockets, at least so the right version is explicitly retrieved
Add static constructor with [InitializeOnLoad] attribute to cache project hash and name at startup. Introduce volatile _identityCached flag and cached values (_cachedProjectName, _cachedProjectHash) to store computed identity. Schedule cache refresh on initialization and when project changes via EditorApplication.projectChanged event. Extract ComputeProjectHash and ComputeProjectName as private methods that perform the actual computation. Update public
Fix: Automatic bridge reconnection after domain reload without requir…
Replace Foldout with VisualElement for http-server-command-section to display HTTP server command directly without collapsible wrapper. Remove unused manualConfigFoldout field and associated CSS styles. Remove unused _identityCached volatile flag from ProjectIdentityUtility as caching logic no longer requires it.
Trying to avoid to monolithic files, this is easier to work, for humans and LLMs
We also fix the Python/uv detectors. Instead of searching for binaries, we just test that they're available in the PATH
…d stdio These only work for JSON configs, we'll have to handle Codex and Claude Code separately
It's better than checking the JSON and it can verify both HTTP and stdio setups
|
Skipped: This PR changes more files than the configured file change limit: ( |
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 103 files out of 298 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| string output = process.StandardOutput.ReadToEnd().Trim(); | ||
| process.WaitForExit(5000); | ||
|
|
||
| if (process.ExitCode == 0 && output.StartsWith("uv ")) |
There was a problem hiding this comment.
Bug: Incorrect uvx version string validation
The validation logic checks if output starts with uv (including a space), but uvx --version typically outputs uvx followed by the version. This mismatch causes valid uvx installations to be rejected, forcing fallbacks or failures.
| if (!string.IsNullOrEmpty(fromUrl)) | ||
| { | ||
| args.Insert(0, fromUrl); | ||
| args.Insert(0, "--from"); |
There was a problem hiding this comment.
Bug: Incompatible arguments used for uv binary fallback
If the detector falls back to the uv binary (instead of uvx), the generator still applies uvx-specific arguments like --from. The uv command does not support --from directly (it requires tool run), which will cause the server launch to fail.
| // Stdio mode: Use uvx command | ||
| var (uvxPath, fromUrl, packageName) = AssetPathUtility.GetUvxCommandParts(); | ||
|
|
||
| unity["command"] = uvxPath; |
There was a problem hiding this comment.
Bug: Config builder ignores verified uv path argument
The PopulateUnityNode method ignores its uvPath argument, instead re-fetching the path via AssetPathUtility.GetUvxCommandParts. This discards the verified path from McpConfigurationHelper and may result in writing an unverified or default command to the config.
| { | ||
| unity["env"] = new JObject(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Missing UNITY_PROJECT_ROOT in stdio configuration
The generated stdio configuration for uvx does not include the UNITY_PROJECT_ROOT environment variable. Without this variable, the isolated MCP server (running via uvx) cannot detect or access the Unity project path, breaking server functionality.
| string output = process.StandardOutput.ReadToEnd().Trim(); | ||
| process.WaitForExit(5000); | ||
|
|
||
| if (process.ExitCode == 0 && output.StartsWith("uv ")) |
There was a problem hiding this comment.
Bug: Incorrect uvx version string validation
The code validates the uvx binary by checking if the version output starts with "uv " (note the space). However, uvx --version typically outputs "uvx x.y.z". This mismatch causes the validation to fail for valid uvx installations, forcing a fallback to uv or failing detection entirely.
| if (!string.IsNullOrEmpty(fromUrl)) | ||
| { | ||
| args.Insert(0, fromUrl); | ||
| args.Insert(0, "--from"); |
There was a problem hiding this comment.
Bug: Invalid arguments generated for uv binary fallback
When the detector falls back to the uv binary (e.g., if uvx detection fails), the configuration builder incorrectly applies uvx-specific arguments (like --from) to the uv command. The uv binary does not support --from directly (it requires tool run), which will cause the generated command to fail.
| // Stdio mode: Use uvx command | ||
| var (uvxPath, fromUrl, packageName) = AssetPathUtility.GetUvxCommandParts(); | ||
|
|
||
| unity["command"] = uvxPath; |
There was a problem hiding this comment.
Bug: Config builder ignores verified uv path argument
The PopulateUnityNode method accepts a uvPath argument (likely verified by the caller), but ignores it completely. It instead calls AssetPathUtility.GetUvxCommandParts() which performs a fresh, potentially unverified or defaulted lookup (e.g., returning "uvx" string literal), discarding the robust path resolution performed earlier.
| { | ||
| unity["env"] = new JObject(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Missing project root environment variable in config
The generated configuration for stdio/uvx mode does not include the UNITY_PROJECT_ROOT environment variable (unlike the CI configuration). Without this variable, the isolated MCP server process may fail to locate or interact with the correct Unity project instance.
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
- Mark prefab stage scene as dirty when manage_components adds/removes/ modifies components, ensuring save_open_stage correctly detects changes - When renaming the root GameObject of an open prefab stage, also rename the prefab asset file to match, preventing Unity's "file name must match" dialog from interrupting automated workflows - Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab before ChildPrefab.prefab to avoid missing prefab reference errors - Remove incorrect LogAssert.Expect that expected an error that doesn't occur in the test scenario Addresses #97 (Prefab Editor Inspection & Modification Support) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
…rces
- Mark prefab stage scene as dirty when manage_components adds/removes/
modifies components, ensuring save_open_stage correctly detects changes
- When renaming the root GameObject of an open prefab stage, also rename
the prefab asset file to match, preventing Unity's "file name must
match" dialog from interrupting automated workflows
- Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab
before ChildPrefab.prefab to avoid missing prefab reference errors
- Remove incorrect LogAssert.Expect that expected an error that doesn't
occur in the test scenario
- Add new prefab MCP resources for inspecting prefabs:
- mcpforunity://prefab-api: Documentation for prefab resources
- mcpforunity://prefab/{path}: Get prefab asset info
- mcpforunity://prefab/{path}/hierarchy: Get full prefab hierarchy
Addresses #97 (Prefab Editor Inspection & Modification Support)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
…rces
- Mark prefab stage scene as dirty when manage_components adds/removes/
modifies components, ensuring save_open_stage correctly detects changes
- When renaming the root GameObject of an open prefab stage, also rename
the prefab asset file to match, preventing Unity's "file name must
match" dialog from interrupting automated workflows
- Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab
before ChildPrefab.prefab to avoid missing prefab reference errors
- Remove incorrect LogAssert.Expect that expected an error that doesn't
occur in the test scenario
- Add new prefab MCP resources for inspecting prefabs:
- mcpforunity://prefab-api: Documentation for prefab resources
- mcpforunity://prefab/{path}: Get prefab asset info
- mcpforunity://prefab/{path}/hierarchy: Get full prefab hierarchy
Addresses #97 (Prefab Editor Inspection & Modification Support)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
…rces
- Mark prefab stage scene as dirty when manage_components adds/removes/
modifies components, ensuring save_open_stage correctly detects changes
- When renaming the root GameObject of an open prefab stage, also rename
the prefab asset file to match, preventing Unity's "file name must
match" dialog from interrupting automated workflows
- Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab
before ChildPrefab.prefab to avoid missing prefab reference errors
- Remove incorrect LogAssert.Expect that expected an error that doesn't
occur in the test scenario
- Add new prefab MCP resources for inspecting prefabs:
- mcpforunity://prefab-api: Documentation for prefab resources
- mcpforunity://prefab/{path}: Get prefab asset info
- mcpforunity://prefab/{path}/hierarchy: Get full prefab hierarchy
Addresses #97 (Prefab Editor Inspection & Modification Support)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
…rces
- Mark prefab stage scene as dirty when manage_components adds/removes/
modifies components, ensuring save_open_stage correctly detects changes
- When renaming the root GameObject of an open prefab stage, also rename
the prefab asset file to match, preventing Unity's "file name must
match" dialog from interrupting automated workflows
- Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab
before ChildPrefab.prefab to avoid missing prefab reference errors
- Remove incorrect LogAssert.Expect that expected an error that doesn't
occur in the test scenario
- Add new prefab MCP resources for inspecting prefabs:
- mcpforunity://prefab-api: Documentation for prefab resources
- mcpforunity://prefab/{path}: Get prefab asset info
- mcpforunity://prefab/{path}/hierarchy: Get full prefab hierarchy
Addresses #97 (Prefab Editor Inspection & Modification Support)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
…rces
- Mark prefab stage scene as dirty when manage_components adds/removes/
modifies components, ensuring save_open_stage correctly detects changes
- When renaming the root GameObject of an open prefab stage, also rename
the prefab asset file to match, preventing Unity's "file name must
match" dialog from interrupting automated workflows
- Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab
before ChildPrefab.prefab to avoid missing prefab reference errors
- Remove incorrect LogAssert.Expect that expected an error that doesn't
occur in the test scenario
- Add new prefab MCP resources for inspecting prefabs:
- mcpforunity://prefab-api: Documentation for prefab resources
- mcpforunity://prefab/{path}: Get prefab asset info
- mcpforunity://prefab/{path}/hierarchy: Get full prefab hierarchy
Addresses #97 (Prefab Editor Inspection & Modification Support)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dsarno
added a commit
that referenced
this pull request
Jan 26, 2026
…rces (CoplayDev#627) - Mark prefab stage scene as dirty when manage_components adds/removes/ modifies components, ensuring save_open_stage correctly detects changes - When renaming the root GameObject of an open prefab stage, also rename the prefab asset file to match, preventing Unity's "file name must match" dialog from interrupting automated workflows - Fix ManagePrefabsCrudTests cleanup order: delete NestedContainer.prefab before ChildPrefab.prefab to avoid missing prefab reference errors - Remove incorrect LogAssert.Expect that expected an error that doesn't occur in the test scenario - Add new prefab MCP resources for inspecting prefabs: - mcpforunity://prefab-api: Documentation for prefab resources - mcpforunity://prefab/{path}: Get prefab asset info - mcpforunity://prefab/{path}/hierarchy: Get full prefab hierarchy Addresses #97 (Prefab Editor Inspection & Modification Support) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds HTTP transport with WebSocket plugin hub, refactors server/Unity transport (keeping stdio), switches to uvx, and makes tools/resources async with new custom-tool registration; updates docs, tests, and packaging.
unity_transport,IMcpTransportClient, stdio/websocket clients) and manager on Unity side.Server/; switch runtime touvx(remote git package) and add Dockerfile + docker-compose./register-tools), with C# attributes for metadata.Written by Cursor Bugbot for commit 9af504c. This will update automatically on new commits. Configure here.