Merge branch 'release/0.1.2'

dsanders11 · May 3, 2019 · c7f7512 · c7f7512
2 parents 080b5f9 + 4cba42e
commit c7f7512
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 21 deletions.
diff --git a/demo/main.js b/demo/main.js
@@ -1,7 +1,9 @@
 import Vue from 'vue'
 import App from './App.vue'
 import VueRouter from 'vue-router'
-import SimplePortal, { config as PortalConfig } from '../package/dist/index.mjs' // from '../src'
+import SimplePortal, {
+  config as PortalConfig,
+} from /*'../src'*/ '../package/dist/index.mjs'
 
 Vue.use(VueRouter)
 Vue.use(SimplePortal)
@@ -31,9 +33,6 @@ const router = new VueRouter({
   ],
 })
 Vue.config.productionTip = false
-const customTarget = document.createElement('DIV')
-customTarget.id = 'custom-target'
-document.body.append(customTarget)
 
 new Vue({
   router,

diff --git a/package/README.md b/package/README.md
@@ -19,10 +19,10 @@ Minimal example:
 
 ```html
 <body>
-  <script src="https://unkpg.com/vue/dist/vue.js"></script>
-  <script src="https://unkpg.com/@linusborg/vue-simple-portal"></script>
+  <script src="https://unpkg.com/vue/dist/vue.js"></script>
+  <script src="https://unpkg.com/@linusborg/vue-simple-portal"></script>
   <div id="app">
-    <-- your Vue app mounts to this element -->
+    <!-- your Vue app mounts to this element -->
   </div>
 
   <div id="portal-target">
@@ -53,9 +53,9 @@ I'm the author of [portal-vue](https://github.com/LinusBorg/portal-vue), a prett
 
 _Why publish another Portal component?_
 
-Well, `portal-vue` was my first sucessful library, and I wanted it to be _awesome_, so I packed it full of features to portal _anything_ to _anywhere_, _anytime_ you want.
+Well, `portal-vue` was my first successful library, and I wanted it to be _awesome_, so I packed it full of features to portal _anything_ to _anywhere_, _anytime_ you want.
 
-That' turned out pretty well, but there were two issues that I found over time, so I wrote a smaller lib that adresses these issues while sliming down on features and (= bundle size) in order to concentrate on the main use case.
+That turned out pretty well, but also means the library is not exactly *tiny* anymore, and there also were a few issues that I found over time, so I wrote a smaller lib that adresses these issues while sliming down on features and (= bundle size) in order to concentrate on the main use case.
 
 <details>
   <summary>
@@ -126,8 +126,8 @@ Just include it with a script tag *after* Vue itself
 
 ```html
 <head>
-  <script src="https://unkpg.com/vue/dist/vue.js"></script>
-  <script src="https://unkpg.com/vue-simple-portal"></script>
+  <script src="https://unpkg.com/vue/dist/vue.js"></script>
+  <script src="https://unpkg.com/vue-simple-portal"></script>
 </head>
 ```
 

diff --git a/package/dist/index.mjs b/package/dist/index.mjs
@@ -1,7 +1,7 @@
 
 /**
  * vue-simple-portal
- * version: 0.1.1,
+ * version: 0.1.2,
  * (c) Thorsten Lünborg, 2019
  * LICENCE: Apache-2.0
  * http://github.com/linusborg/vue-simple-portal
@@ -125,7 +125,7 @@ var Portal = Vue.extend({
       if (!isBrowser) return;
       var parent = document.querySelector('body');
       var child = document.createElement(this.tag);
-      child.id = config.selector;
+      child.id = this.selector.substring(1);
       parent.append(child);
     },
     mount: function mount() {

diff --git a/package/dist/index.umd.js b/package/dist/index.umd.js
@@ -1,7 +1,7 @@
 
 /**
  * vue-simple-portal
- * version: 0.1.1,
+ * version: 0.1.2,
  * (c) Thorsten Lünborg, 2019
  * LICENCE: Apache-2.0
  * http://github.com/linusborg/vue-simple-portal
@@ -159,7 +159,7 @@
         if (!isBrowser) return;
         var parent = document.querySelector('body');
         var child = document.createElement(this.tag);
-        child.id = config.selector;
+        child.id = this.selector.substring(1);
         parent.append(child);
       },
       mount: function mount() {

diff --git a/package/dist/index.umd.min.js b/package/dist/index.umd.min.js