Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: theory page #76

Merged
merged 5 commits into from
Aug 4, 2020
Merged

Documentation: theory page #76

merged 5 commits into from
Aug 4, 2020

Conversation

gasse
Copy link
Member

@gasse gasse commented Jul 31, 2020

Pull request checklist

  • I have checked that the documentation compiles on the CI server (LaTex libraries for rendreing math might be missing)

This is a first draft, I tried to be clear and concise. Let me know what you think !

@AntoinePrv
Copy link
Member

I see the error

LaTeX command 'latex' cannot be run (needed for math display), check the imgmath_latex setting

Does the documentation build correctly on your computer? Latex would be a dependency for math instructions?
Perhaps we can substitute to MathJax, may be a lighter solution

@gasse
Copy link
Member Author

gasse commented Aug 1, 2020

Yes on my laptop it works fine. I'll try to switch to Mathjax, however I am not sure I can use the latex customization I am using now. I'll let you know. Otherwise, do you think it could be reasonable to have a working (minimal) latex distro within the CI chain ?

@AntoinePrv
Copy link
Member

So I tried the current branch on my computer (with Latex) and it did not work. I don't look forward to fighting with Latex inside the CI environment.

With MathJax, I replaced

extensions += ["sphinx.ext.imgmath"]
imgmath_image_format = "svg"

With

extensions += ["sphinx.ext.mathjax"]

And it worked directly, except for the preamble that is not supported.
Could we not inline it's content? argmax does not seem very complicated to reproduce.
What is nindep supposed to do?

@AntoinePrv
Copy link
Member

Also, I've been using "Ecole" (v.s. "ECOLE") in text to refer to the library. I believe should decide on one and stay homogeneous.

@gasse
Copy link
Member Author

gasse commented Aug 3, 2020

I got rid of LaTex, let me know if that works for you.
I also changed ECOLE for Ecole, I agree it looks best in the text.

Note: equation numbers do not render properly, this seems to be an old bug of the Sphinx theme we are using:
readthedocs/sphinx_rtd_theme#383

Probably we could fix it by tweaking the CSS a bit. Or we can just wait for a fix.

@AntoinePrv
Copy link
Member

Seems to work, I'm rebasing to fix the CI.

I have the same bug of equation number, I'll try to see If I can add the CSS from the issue.

Copy link
Member

@AntoinePrv AntoinePrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gasse
Copy link
Member Author

gasse commented Aug 4, 2020

There was still a glitch with chrome, I tweaked a bit the CSS, looks like it fixed it. All good for me, you can merge @AntoinePrv if you want

@AntoinePrv AntoinePrv merged commit a96302b into master Aug 4, 2020
@AntoinePrv AntoinePrv deleted the doc_theory branch August 4, 2020 16:06
dmey added a commit to dmey/synthia that referenced this pull request Sep 22, 2020
Copy link

@PhantomRwcwride2Zero PhantomRwcwride2Zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry there is no merging when that pull happen because that was things that someone stole from me and we was just trying to get them back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants