Skip to content

Sync for all components not only interfaces#7

Merged
drygdryg merged 11 commits intodrygdryg:masterfrom
rizlas:master
Jan 20, 2022
Merged

Sync for all components not only interfaces#7
drygdryg merged 11 commits intodrygdryg:masterfrom
rizlas:master

Conversation

@rizlas
Copy link
Copy Markdown
Contributor

@rizlas rizlas commented Jan 12, 2022

Hi,
first of all thank you for your plugin. I made a fork of it and added the possibility to sync all NetBox components. I tested it with NetBox 3.1.5 and it is entirely working.
I mainly used your business logic, but the quality of the code can still be improved as there are repeating or decentralized pieces of code (example: PowerOutletComparisonView, FrontPortComparisonView). I also changed the table rendering using bootstrap 5 and by removing the double table. The comparison of the objects is now done on all fields and not only on the name, you can see in detail in comparison.py.
Added a new variable that allows you to choose whether to display the interface summary panel or not.

Further renaming changes are needed for consistency, as the plugin no longer includes just interfaces, but I leave these changes to you.

This upgrade closes #3

Thank you

@drygdryg
Copy link
Copy Markdown
Owner

I will review this shortly and accept

@rizlas
Copy link
Copy Markdown
Contributor Author

rizlas commented Jan 14, 2022

Thank you, I developed in a hurry and as I said the quality of the code should/must be improved. Anyway I'm here if you want me to modify something before closing the PR.

@drygdryg
Copy link
Copy Markdown
Owner

drygdryg commented Jan 17, 2022

Thank you for your hard work! It would be nice to add the ability to compare components, ignoring their descriptions. This could be an option in the PLUGINS_CONFIG. Can you implement it or do you want to leave this task to me?

@rizlas
Copy link
Copy Markdown
Contributor Author

rizlas commented Jan 18, 2022

Hi,
I implemented it and tested. Seems ok. If compare_description is True, description is also synced to device otherwise not.

For default value, pick whatever you like :-)

Thank you!

@drygdryg drygdryg merged commit de4e730 into drygdryg:master Jan 20, 2022
@drygdryg
Copy link
Copy Markdown
Owner

Thank you for your contribution!

@rizlas
Copy link
Copy Markdown
Contributor Author

rizlas commented Jan 20, 2022

Thanks to you, looking forward for the new release

@AnythingOverIP
Copy link
Copy Markdown

When will we have the chance to have this included in a release?

@rizlas
Copy link
Copy Markdown
Contributor Author

rizlas commented Aug 16, 2023

You can use my fork if you want.. Its been two years, I don't know if it will ever be released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend module to support other "components"

3 participants