Sync for all components not only interfaces#7
Conversation
…arison class. Check all fields in poweroutlet object for sync. Added update strategy if an object already exists.
… Added str method to comparison classes.
|
I will review this shortly and accept |
|
Thank you, I developed in a hurry and as I said the quality of the code should/must be improved. Anyway I'm here if you want me to modify something before closing the PR. |
|
Thank you for your hard work! It would be nice to add the ability to compare components, ignoring their descriptions. This could be an option in the |
…it should be synced in device
|
Hi, For default value, pick whatever you like :-) Thank you! |
|
Thank you for your contribution! |
|
Thanks to you, looking forward for the new release |
|
When will we have the chance to have this included in a release? |
|
You can use my fork if you want.. Its been two years, I don't know if it will ever be released |
Hi,
first of all thank you for your plugin. I made a fork of it and added the possibility to sync all NetBox components. I tested it with NetBox 3.1.5 and it is entirely working.
I mainly used your business logic, but the quality of the code can still be improved as there are repeating or decentralized pieces of code (example:
PowerOutletComparisonView,FrontPortComparisonView). I also changed the table rendering using bootstrap 5 and by removing the double table. The comparison of the objects is now done on all fields and not only on the name, you can see in detail incomparison.py.Added a new variable that allows you to choose whether to display the interface summary panel or not.
Further renaming changes are needed for consistency, as the plugin no longer includes just interfaces, but I leave these changes to you.
This upgrade closes #3
Thank you