Adds an item abstraction to Memoizable and Callable Items #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a Factory to create an Item * Adds Memoizable and Callable classes to avoid some conditions fix travis try again
GabrielMalakias
force-pushed
the
readability_improvements
branch
from
d1cb49a
to
3de8385
Compare
|
Wow, thanks @GabrielMalakias, nice work 👍 Thanks for the PR and using dry-rb 😄 |
flash-gordon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I love dry-rb tools, I try to use it in my projects everytime that I can (Great work dry-rb Team!), then I decided to make a change code proposal.
I created a Factory to create a Memoizable Item or a Callable item. When options has the memoize option as true the Memoizable object is created, but if isn't true, the Callable object is used.