Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy to 1.6.1 #1710

Closed
wants to merge 1 commit into from
Closed

Bump mypy to 1.6.1 #1710

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

Closes #1709

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7f025d8) to head (be04f3e).
Report is 184 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1710   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines         2485      2485           
  Branches       437       437           
=========================================
  Hits          2485      2485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andersk
Copy link

andersk commented Nov 15, 2023

Bisecting mypy shows that both failures were first triggered by python/mypy@14418bc:

@sobolevn
Copy link
Member Author

Yeap, I have to rework how detach_callable works now.

@thepabloaguilar
Copy link
Member

Hey @sobolevn, I can take this to fix!

@sobolevn
Copy link
Member Author

Sure, please, go ahead :)

@thepabloaguilar
Copy link
Member

I've tried but I have no idea 😄

Why do you think detach_callable is the problem?

@sobolevn
Copy link
Member Author

yes :)

@sobolevn sobolevn mentioned this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants