Skip to content

Mypy 1.6.1 fails with returns 0.21.0 on use of curry.partial #1711

Open
#2094
Open
Mypy 1.6.1 fails with returns 0.21.0 on use of curry.partial#1711
#2094
Labels
bugSomething isn't working

Description

@petergaultney
petergaultney
opened on Oct 19, 2023

Bug report

I think mypy 1.6 has broken your plugin again. It seems like their API changes quite a lot. :(

What's wrong

my_partial = returns.curry.partial(foo, bar=baz(1))
reveal_type(my_partial)

Running mypy 1.6.1 against this, with the plugin installed and activated, results in:

https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.6.1
Traceback (most recent call last):
  File "mypy/checkexpr.py", line 5374, in accept
  File "mypy/nodes.py", line 1907, in accept
  File "mypy/checkexpr.py", line 452, in visit_call_expr
  File "mypy/checkexpr.py", line 581, in visit_call_expr_inner
  File "mypy/checkexpr.py", line 1420, in check_call_expr_with_callee_type
  File "mypy/checkexpr.py", line 1514, in check_call
  File "mypy/checkexpr.py", line 1734, in check_callable_call
  File "mypy/checkexpr.py", line 1194, in apply_function_plugin
  File "*/.venv/lib/python3.11/site-packages/returns/contrib/mypy/_features/partial.py", line 67, in analyze
    ).new_partial()
      ^^^^^^^^^^^^^
  File "*/.venv/lib/python3.11/site-packages/returns/contrib/mypy/_features/partial.py", line 135, in new_partial
    partial = self._create_partial_case(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "*/.venv/lib/python3.11/site-packages/returns/contrib/mypy/_features/partial.py", line 167, in _create_partial_case
    ).from_usage(self._applied_args)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "*/.venv/lib/python3.11/site-packages/returns/contrib/mypy/_typeops/inference.py", line 61, in from_usage
    constraints = self._infer_constraints(applied_args)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "*/.venv/lib/python3.11/site-packages/returns/contrib/mypy/_typeops/inference.py", line 83, in _infer_constraints
    constraints = infer_constraints_for_callable(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: infer_constraints_for_callable() missing required argument 'context' (pos 6)

How is that should be

path/to/execution.py:21: note: Revealed type is "def (id: builtins.str, df: Any, *, schema: Union[builtins.str, None] =) -> FooBarBaz"

System information

  • python version: 3.11.4

  • returns version: 0.21.0

  • mypy version: 1.6.1

  • pytest version (if any): 7.2.1

Activity

  1. petergaultney
    added
    bugSomething isn't working
    on Oct 19, 2023

  2. sobolevn commented on Oct 19, 2023

    @sobolevn
    sobolevn
    on Oct 19, 2023
    Member

    Yes, I am aware :(
    Working on a fix, please use 1.5 in the meantime

  3. petergaultney commented on Oct 19, 2023

    @petergaultney
    petergaultney
    on Oct 19, 2023
    Author

    thank you!

    completely unrelated question, and forgive me for hijacking the issue, but I couldn't find any info on this in the changelog... Why does 0.22 not support Python 3.8.0? The >=3.8.1 requirement is sort of tricky to work with even though I don't have an explicit need for 3.8.0.

  4. sobolevn commented on Oct 19, 2023

    @sobolevn
    sobolevn
    on Oct 19, 2023
    Member

    3.8.0 is broken :(

  5. RamiAwar commented on Feb 15, 2024

    @RamiAwar
    RamiAwar
    on Feb 15, 2024

    Any update on this? Still seeing it today!

      File "/Users/rami/.vscode/extensions/ms-python.mypy-type-checker-2023.6.0/bundled/libs/mypy/checkexpr.py", line 1194, in apply_function_plugin
    return callback(
           ^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/returns/contrib/mypy/_features/partial.py", line 66, in analyze
    ).new_partial()
      ^^^^^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/returns/contrib/mypy/_features/partial.py", line 134, in new_partial
    partial = self._create_partial_case(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/returns/contrib/mypy/_features/partial.py", line 166, in _create_partial_case
    ).from_usage(self._applied_args)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/returns/contrib/mypy/_typeops/inference.py", line 60, in from_usage
    constraints = self._infer_constraints(applied_args)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/returns/contrib/mypy/_typeops/inference.py", line 82, in _infer_constraints
    constraints = infer_constraints_for_callable(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: infer_constraints_for_callable() missing 1 required positional argument: 'context'

  6. Jazzinghen commented on Mar 22, 2024

    @Jazzinghen
    Jazzinghen
    on Mar 22, 2024
    Contributor

    I've also encountered this issue.
    Is there anything I can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions