Support the glob pattern in root_dir and model_dir
#198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We often want to specify multiple directories in `root_dir` and `model_dir`. For example, when using engines, packs-rails, etc. * https://github.com/rubyatscale/packs-rails * https://guides.rubyonrails.org/engines.html This commit supports the glob pattern with these options, making it easy to specify multiple directories. fixes drwl#99
sinsoku
force-pushed
the
support-glob-pattern
branch
from
f6d4773 to
08f527c
Compare
|
@sinsoku just checking -- have you been able to try these changes in your local? I don't have a Rails app with packwerk setup to test. |
drwl
approved these changes
Apr 5, 2025
|
@drwl I have tested it in a Rails app using packwerk. |
|
Also successfully tested this in a large Packwerked application. Thank you both for the contributions here! |
|
Thanks for the confirmations @sinsoku and @jarredhawkins . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often want to specify multiple directories in
root_dirandmodel_dir.For example, when using engines, packs-rails, etc.
This commit supports the glob pattern with these options, making it easy
to specify multiple directories.
fixes #99