Allow integration tests to test commands that have confirmations #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
commented
Dec 11, 2018
| @@ -133,7 +133,7 @@ protected function buildCommandLine($command, $args, $options) | |||
| } | |||
| // insert drush command options | |||
| foreach ($options as $key => $value) { | |||
| if (!isset($value)) { | |||
| if (!isset($value) || $value === true) { | |||
There was a problem hiding this comment.
Usually, 'yes' => true gives --yes, and 'yes' => '1' gives --yes=1. I've always found the Unish-style 'yes' => null to be confusing. Would it be okay to switch to true everywhere? We should also support null for external unish clients.
…ts (pass --yes to confirm).
greg-1-anderson
force-pushed
the
integration-tests-with-confirmations
branch
from
b6cbfc0 to
a12175a
Compare
|
Just one trivial question before merging. We can stick with |
weitzman
approved these changes
Dec 11, 2018
| @@ -102,7 +102,7 @@ public function drush($command, array $args = [], array $options = [], $expected | |||
| protected function buildCommandLine($command, $args, $options) | |||
| { | |||
| $global_option_list = ['simulate', 'root', 'uri', 'include', 'config', 'alias-path', 'ssh-options', 'backend', 'cd']; | |||
| $options += ['root' => $this->webroot(), 'uri' => self::INTEGRATION_TEST_ENV]; // Default value. | |||
| $options += ['root' => $this->webroot(), 'uri' => self::INTEGRATION_TEST_ENV, 'strict' => 0]; // Default value. | |||
There was a problem hiding this comment.
Disabling strict mode bypasses argument validation. We can try without this.
tests/integration/WatchdogTest.php
Outdated
| { | ||
|
|
||
| public function testWatchdog() | ||
| { | ||
| $this->setUpDrupal(1, true); | ||
| $this->drush('pm-enable', ['dblog']); | ||
| $this->drush('pm-enable', ['dblog'], [], self::IGNORE_EXIT_CODE); |
There was a problem hiding this comment.
We might enable modules again and again. I guess that enabling an already-enabled module is not an error, so we can remove this.
…geTest to an integration test.
|
It worked to remove strict mode; it was also fine to remove the ignore errors flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass --yes to confirm.